Unpacking from archive fails if path contains cyrillic symbols

Bug #1812516 reported by Aleksandr Sh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Low
Seth Hillbrand

Bug Description

1. Create a folder named "Рабочая папка"
2. Archive a project into it. This works.
3. Try to unarchive that zip. It does not create any files to the output directory

Application: kicad
Version: (6.0.0-rc1-dev-1535-ge7fa02a9f), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: wxwidgets
Revision history for this message
Seth Hillbrand (sethh) wrote :

This appears to be a wx issue but we might get around it using a different archive method in v6

Changed in kicad:
importance: Undecided → Low
milestone: none → 6.0.0-rc1
status: New → Triaged
Revision history for this message
jean-pierre charras (jp-charras) wrote :

I cannot reproduce this issue on W7 32 bits

Revision history for this message
Aleksandr Sh (dsa-t) wrote :

There seem to be a workaround for that: https://trac.wxwidgets.org/ticket/17244

Revision history for this message
Aleksandr Sh (dsa-t) wrote :

jp-charras, make sure you have the archive in "Рабочая папка"

Revision history for this message
jean-pierre charras (jp-charras) wrote :

OK.
It happens on wxWidgets 3.04, not on wxWidgets 3.1.1
Looks like is is fixed in wxWidgets.

tags: added: wxwidgets
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 3a1e66dba3e4fa7b658d30b742e9bc66b7fac896
https://git.launchpad.net/kicad/patch/?id=3a1e66dba3e4fa7b658d30b742e9bc66b7fac896

Changed in kicad:
status: Triaged → Fix Committed
assignee: nobody → Seth Hillbrand (sethh)
Revision history for this message
jean-pierre charras (jp-charras) wrote :

Unfortunately, the bug is not fixed (W7, wxWidgets 3.04).
The archive is still empty: files named "Рабочая папка.xxx" are not stored in archive

Revision history for this message
Seth Hillbrand (sethh) wrote :

Hi JP- That part is not fixable in the same way as this bug report. URI encoding of the input files results in archive names that are encoded with a string of '%xx' blocks. This is unreadable to me, so I suspect others would not like it.

As you note, all aspects are fixing in wx 3.1, so we might wait for the next wx or change to a different method of archiving in v6. Thoughts?

Revision history for this message
jean-pierre charras (jp-charras) wrote :

Hi Seth,

Yes, I know... and name encoded as '%xx' blocks are not usable.
Because it is already fixed in wx 3.1, we could wait for the next wxWidgets version.

Non ascii7 chars and spaces in paths always create issues, not only in Kicad, but in many other tools, and/or in scripts.
For instance in OCE for 3D step files.
When I right click on the file "Рабочая папка.sch" to open it inside my editor (SciTE), the editor cannot open this file.
I am able to open it from my editor, but not from the Windows File manager...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.