Wishlist: Shortcut key to quickly log out

[Terran McCanna]

We've had a wish list request from a library for a shortcut / function key to call the Log Out function in the web client.

[Stephanie Leary (stephanieleary)]

I came across this while working on some other things related to shortcuts, and I agree it would be nice. I've done a quick patch using Alt+Shift+Q as the shortcut. I checked OS, browser, and screen reader keyboard shortcuts for conflicts and didn't find any.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp1812414-logout-shortcut

However, I think this needs some discussion. Do we want to throw in a confirmation dialog, in case of accidents?

[Andrea Neiman (aneiman)]

+1 to a confirmation

[Jason Boyer (jboyer)]

I also think that a confirmation would be good, though I would also like to see that paired with a user (rather than workstation) setting because I would also turn it off. :)

[Stephanie Leary (stephanieleary)]

Noting that it does us little good to have a keyboard shortcut for logging out if the resulting confirmation screen can't be dismissed via the keyboard; see bug 1826584

[Stephanie Leary (stephanieleary)]

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/sleary/lp1812414-logout-shortcut

Updated branch, with help from Galen and Mike on figuring out that we needed to change from a directive to a component to make AccessKeys show a dialog.

This makes it possible for other keyboard shortcuts to implement confirmations before the requested action is taken.

[Blake GH (bmagic)]

Merge conflict today (feedback fest)

[Michele Morgan (mmorgan)]

This is merging cleanly for me to main.

[Michele Morgan (mmorgan)]

Merges cleanly for me!

[Blake GH (bmagic)]

After installing this patch, the nav menu's are messed up. See screen shot. It could* be an issue with playing with the other patches on the machine. The patch did merge cleanly.

[Galen Charlton (gmc)]

I'm seeing the same thing (upon dealing with the merge conflict now that bug 1828468 is pushed). Upon inspection, it looks like the template supplied by the attribute-selected component is replacing the contents of the <a> elements in the navbar when an access key is defined.

It looks like the following might work:

- change it back to a directive
- tack the eg-confirm-dialog (or maybe an ng-template containing it) to the navbar somewhere
- add a second @Input() to the directive that accepts a TemplateRef or a ConfirmDialogComponent, and pass it to each and every element that uses the accesskey directive similar to https://stackoverflow.com/a/75542708.

[Stephanie Leary (stephanieleary)]

Rather than get tangled up in Angular components vs. directives in order to make confirmation dialogs easy for all keyboard shortcuts everywhere, I am vastly simplifying the solution here. The Alt+Shift+Q shortcut now calls a function that presents the confirmation dialog and, if confirmed, logs out.

Branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp1812414-logout-shortcut-revised

[Michele Morgan (mmorgan)]

Thanks for your work on this Stephanie. I've tested this patch, and unfortunately, while the Alt+Shift+Q quickly and easily performs the logout, the confirmation dialog is never presented.

Putting back the needswork tag.

[Stephanie Leary (stephanieleary)]

Thanks, Michele! Somehow the revised branch had only half the relevant changes. I've just updated and squashed it.

[Shula Link (slink-g)]

Tested; looks to be working and signed off here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=5f443b7889d71c41bccccf599c0e9957a2166578

[Terran McCanna (tmccanna)]

Thanks Stephanie and Shula, fix committed!