system modify command does not accept capitalized True/False

[Michel Thebeau [WIND]]

Title
-----
system modify command does not accept capitalized True/False

Brief Description
-----------------
Only "true" and "false" are accepted by the 'system modify' command options --https_enabled and --sdn_enabled.

Severity
--------
Minor

Steps to Reproduce
------------------
These example commands:

system modify --https_enabled=True
system modify --sdn_enabled=False

Where as 'system show' command display "True" or "False"

Expected Behavior
------------------
true/false options should be case insensitive

Actual Behavior
----------------
true/false options are only accepted as "true" and "false".

Reproducibility
---------------
Reproducible

System Configuration
--------------------
any

Branch/Pull Time/Commit
-----------------------
2019-01-16_20-18-01
starlingx/master

Timestamp/Logs
--------------

# system show | grep "https_enabled\|sdn_enabled"
| https_enabled | True |
| sdn_enabled | False |

# system modify --https_enabled False
...
system modify: error: argument -p/--https_enabled: invalid choice: 'False' (choose from 'true', 'false')

# system modify --sdn_enabled=True
...
system modify: error: argument -s/--sdn_enabled: invalid choice: 'True' (choose from 'true', 'false')

[Ghada Khalil (gkhalil)]

Marking as release gating. This is a minor issue, but all sysinv cmds should be aligned and behave similarly (assuming other cmds accept: true/True false/False).

This is also a good learning opportunity for someone ramping up on StarlingX

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/632017

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/632017
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=2b2782efb6ea2efc4816fe67287c8a0515916352
Submitter: Zuul
Branch: master

commit 2b2782efb6ea2efc4816fe67287c8a0515916352
Author: sunausti <email address hidden>
Date: Mon Jan 21 01:04:02 2019 +0000

    Support 'True' and 'False' input for system commands

    add args choice 'True' and 'False' for https_enabled and sdn_enabled
    in 'system modify' and for dynamic in 'system network-add' command
    to support input 'True' and 'False'.

    make https_enabled and sdn_enabled to lower case in sys-api controller

    Closes-bug: 1812268

    Change-Id: If6411852edfc970ee1d749e4d4ccb8d045767bbc
    Signed-off-by: sunausti <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/stein
Review: https://review.openstack.org/633788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/633788
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=23f303132c9e69a16f2e0b1b63483c49fcfd11a1
Submitter: Zuul
Branch: f/stein

commit 3cc2f5e1fb70159473eefe4e5141db4eab8c92b0
Author: Al Bailey <email address hidden>
Date: Mon Jan 28 09:50:25 2019 -0600

    Change version of python-ldap to work with new setuptools

    setuptools 40.7.0 does not work with python-ldap 2.5.2

    Added unit tests to verify the code calling the python-ldap
    functions.

    Closes-Bug: 1813668
    Change-Id: I1e5c0bb7ec603d4d2e03032282e268cb2189775d
    Signed-off-by: Al Bailey <email address hidden>

commit c4f63232dc88bd8eae5698b104011cbc7d7f98ea
Author: Bart Wensley <email address hidden>
Date: Mon Jan 28 13:17:00 2019 -0600

    Ensure puppet dns config done after networking config

    In some labs, the puppet manifest application during
    config_controller results in the ::platform::network class
    being applied after the ::platform::dns class. This causes the
    /etc/resolv.conf file to be wiped (when the
    apply_network_config.sh is run by the ::platform::network
    class).

    The fix is to introduce a dependency to ensure that the
    networking config is completed before the dns config is done.

    Change-Id: Ie4a8b67e5eb3594f5c21e22f8014d2b8162a0758
    Related-bug: 1812449
    Signed-off-by: Bart Wensley <email address hidden>

commit de474bc41c2691ba86b60bb6e1088ddc382deaa3
Author: Bart Wensley <email address hidden>
Date: Thu Jan 24 16:33:41 2019 +0000

    Revert "Add docker proxy configuration for kubernetes".

    This change broke the installation of kubernetes system (config_controller --kubernetes) when no docker proxy was specified.

    This reverts commit e4086a073b7f661d4014061f25525120c27ea679.

    Change-Id: I8343741a50fa0857fde9dfe0ee8f81de80a0ff13

commit d96ce5291c78c371e132813a514a1fb6e0994850
Author: Bart Wensley <email address hidden>
Date: Thu Jan 24 07:22:05 2019 -0600

    Allow DNS server configuration for kubernetes

    In kubernetes deployments, a DNS server is required to locate
    the registry servers used to download the kubernetes images.
    Currently, when config_controller is run, the 8.8.8.8
    nameserver is used, with no way to change it. Some users
    need to specify their own name server to be used during
    the execution of config_controller.

    This change allows the user to specify up to three DNS
    servers when running config_controller interactively or with
    a config file. If using a config file, add the following
    section to the config file (only one nameserver is required,
    but up to three are allowed):

    [DNS]
    NAMESERVER_1=8.8.8.8
    NAMESERVER_2=8.8.4.4
    NAMESERVER_3=9.9.9.9

    Change-Id: I59556138a11c6f627f45886a2da6b8a1ad9d89e1
    Closes-bug: 1812449
    Signed-off-by: Bart Wensley <email address hidden>

commit f0b393f30952aa226976c33b9ff9241283fab207
Author: Kevin Smith <email address hidden>
Date: Thu Jan 17 07:09:35 2019 -0500

    Kubernetes Neutron VIM Host Management Ref...