[kernel] natsemi module is broken in Gutsy

[JanL]

Binary package hint: linux-image-2.6.22-14-generic

I installed Ubuntu on my girlfriends Laptop. It works fine, but after a
resume from suspending to disk she has no network.

In the kern.log I've found a bug (file attached) that seems to be
resolved with this fix:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.22.y.git;a=commit;h=c9a06c0099d53aab5853a52076a756c967c121a5

Is it possible to include this fix in the next ubuntu-kernel-update?

--Kern.log:
18 16:28:40 haemmerchen kernel: [ 378.722624] BUG: unable to handle kernel NULL pointer dereference at virtual address 00000020
Dec 18 16:28:40 haemmerchen kernel: [ 378.722633] printing eip:
Dec 18 16:28:40 haemmerchen kernel: [ 378.722635] f8851b7e
Dec 18 16:28:40 haemmerchen kernel: [ 378.722637] *pde = 00000000
Dec 18 16:28:40 haemmerchen kernel: [ 378.722642] Oops: 0000 [#1]
Dec 18 16:28:40 haemmerchen kernel: [ 378.722644] SMP
Dec 18 16:28:40 haemmerchen kernel: [ 378.722648] Modules linked in: battery ac thermal processor fan button natsemi usb_storage ide_core fwlanusb(P) libusual af_packet i915 drm rfcomm l2cap bluetooth ppdev i
pv6 snd_atiixp_modem snd_via82xx_modem snd_intel8x0m speedstep_lib cpufreq_conservative cpufreq_ondemand cpufreq_stats freq_table cpufreq_userspace cpufreq_powersave container sbs dock video lp snd_intel8x0 sn
d_ac97_codec ac97_bus snd_pcm_oss snd_mixer_oss snd_pcm snd_seq_dummy snd_seq_oss snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq joydev snd_timer snd_seq_device parport_pc snd soundcore snd_page_alloc par
port pcspkr serio_raw psmouse shpchp pci_hotplug iTCO_wdt iTCO_vendor_support i2c_i810 intel_agp i2c_algo_bit agpgart i2c_core evdev ext3 jbd mbcache sg sr_mod cdrom sd_mod ata_piix ata_generic libata scsi_mod
 ehci_hcd uhci_hcd usbcore fuse apparmor commoncap
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722724] CPU: 0
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722725] EIP: 0060:[<f8851b7e>] Tainted: P VLI
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722728] EFLAGS: 00210296 (2.6.22-14-generic #1)
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722740] EIP is at natsemi_remove1+0x1e/0x60 [natsemi]
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722744] eax: df8e5c48 ebx: df8e5c00 ecx: df8e5c48 edx: f8855360
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722748] esi: 00000000 edi: f88552b4 ebp: 00000001 esp: f785defc
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722752] ds: 007b es: 007b fs: 00d8 gs: 0033 ss: 0068
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722756] Process rmmod (pid: 7403, ti=f785c000 task=e786e530 task.ti=f785c000)
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722760] Stack: df8e5c00 f88552b4 f88552b4 c02098e6 df8e5c48 c0260f38 df8e5c48 df8e4448
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722768] c0261492 f88552fc f8855300 f8855400 f88552b4 c03b9c80 f785c000 c0260a57
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722777] f8855400 00000000 f8855280 c0209a9e f8855400 00000000 bfde0480 f785c000
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722784] Call Trace:
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722804] [pci_device_remove+22/64] pci_device_remove+0x16/0x40
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722823] [__device_release_driver+104/160] __device_release_driver+0x68/0xa0
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722841] [driver_detach+210/224] driver_detach+0xd2/0xe0
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722878] [bus_remove_driver+103/144] bus_remove_driver+0x67/0x90
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722900] [pci_unregister_driver+14/112] pci_unregister_driver+0xe/0x70
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722930] [sys_delete_module+298/400] sys_delete_module+0x12a/0x190
 Dec 18 16:28:40 haemmerchen kernel: [ 378.722962] [do_munmap+390/480] do_munmap+0x186/0x1e0
 Dec 18 16:28:40 haemmerchen kernel: [ 378.723043] [sysenter_past_esp+107/169] sysenter_past_esp+0x6b/0xa9
 Dec 18 16:28:40 haemmerchen kernel: [ 378.723094] [clip_ioctl+1280/1296] clip_ioctl+0x500/0x510
 Dec 18 16:28:40 haemmerchen kernel: [ 378.723141] =======================
 Dec 18 16:28:40 haemmerchen kernel: [ 378.723143] Code: 74 24 04 83 c4 08 c3 8d b6 00 00 00 00 83 ec 0c ba 60 53 85 f8 89 1c 24 89 c3 89 74 24 04 89 7c 24 08 8b b0 50 01 00 00 8d 40 48 <8b> 7e 20 e8 8a cf a0 c7 89 f0 e8 b3 31 a3 c7 89 d8 e8 ec 4f 9b
 Dec 18 16:28:40 haemmerchen kernel: [ 378.723187] EIP: [<f8851b7e>] natsemi_remove1+0x1e/0x60 [natsemi] SS:ESP 0068:f785defc
 Dec 18 16:30:40 haemmerchen kernel: [ 498.771226] ACPI: PCI interrupt for device 0000:00:1f.6 disabled

[JanL (losinski)]

I hope the problem will be fixed faster by the ubuntu guys if I attach the patch directly!

Here is the original patch from the Kernel.org GIT:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.22.y.git;a=commitdiff;h=c9a06c0099d53aab5853a52076a756c967c121a5;hp=d9e0dded68a8de6a831dd9c31be32a45f4b67373#patch1

Please include it!

[Leann Ogasawara (leannogasawara)]

HI JanL,

Thank you so much for the git commit id, makes things so much easier to track down. This patch is already included in the actively developed Hardy Heron kernel. If you want to test out the new kernel you can download and try the new Hardy Heron Alpha release from http://cdimage.ubuntu.com/releases/hardy/ . You should be able to then test the new kernel via the LiveCD. If you can, please verify if this bug is fixed in Hardy that would be great. General information regarding the release can also be found here: http://www.ubuntu.com/testing/ . Once we can confirm the fix is in the actively developed kernel we can go about trying to get this backported to Gutsy. Thanks.

[JanL (losinski)]

It seems to work with the hardy alpha CD image, please backport it, because my girlfriend want to use her laptops ethernet port.

[Tim Gardner (timg-tpi)]

SRU Justification:

Impact: Removing natsemi ethernet driver causes oops

Fix Description: Fix the NATSEMI_REMOVE_FILE macro which incorrectly uses device_create_file instead of device_remove_file

Patch: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-gutsy.git;a=commit;h=1156022ac789a55d8240d6849a01f4fb05da582d

TEST CASE: See Bug Description

[Tim Gardner (timg-tpi)]

http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-gutsy.git;a=commit;h=1156022ac789a55d8240d6849a01f4fb05da582d

[Martin Pitt (pitti)]

One gutsy task is enough.

[Tim Gardner (timg-tpi)]

2.6.22-15.54

  * netdrvr: natsemi: Fix device removal bug