Cinder

Windows SMB driver regression

Bug #1811369 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Lucian Petrut

Bug Description

The Windows SMB driver has been broken by a recent change [1], which is attempting to handle info file permissions, using the 'truncate' command along the way, which is not available on Windows.

We're not handling file permissions on Windows, so we can just skip this step, avoiding this issue.

Trace: http://paste.openstack.org/raw/741770/

[1] I6c20c4825af0a365b6a20fb633c810c2f2fe48b0

See original description
Lucian Petrut (petrutlucian94)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/630168

Changed in cinder:
assignee: nobody → Lucian Petrut (petrutlucian94)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/630168
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=133617828c37db78bcc71c5106c90818e0bebc3c
Submitter: Zuul
Branch: master

commit 133617828c37db78bcc71c5106c90818e0bebc3c
Author: Lucian Petrut <email address hidden>
Date: Fri Jan 11 13:38:35 2019 +0200

    Avoid using 'truncate' on Windows

    The Windows SMB driver has been broken by a recent change [1],
    which is attempting to handle info file permissions, using the
    'truncate' command along the way, which is not available on Windows.

    We're not handling file permissions on Windows, so we can just skip
    this step, avoiding this issue.

    Change-Id: I1f92cef19cd2eed7ba845210f7ff89d88ba78f49
    Closes-Bug: #1811369

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/631857

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/rocky)

Reviewed: https://review.openstack.org/631857
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=8230238365f5a8b356d1b0af614a62d37aab21d3
Submitter: Zuul
Branch: stable/rocky

commit 8230238365f5a8b356d1b0af614a62d37aab21d3
Author: Lucian Petrut <email address hidden>
Date: Fri Jan 11 13:38:35 2019 +0200

    Avoid using 'truncate' on Windows

    The Windows SMB driver has been broken by a recent change [1],
    which is attempting to handle info file permissions, using the
    'truncate' command along the way, which is not available on Windows.

    We're not handling file permissions on Windows, so we can just skip
    this step, avoiding this issue.

    Change-Id: I1f92cef19cd2eed7ba845210f7ff89d88ba78f49
    Closes-Bug: #1811369
    (cherry picked from commit 133617828c37db78bcc71c5106c90818e0bebc3c)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/634046

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 13.0.3

This issue was fixed in the openstack/cinder 13.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/queens)

Reviewed: https://review.openstack.org/634046
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3fa8a646e174fe1e422f7a7127b3efe2e8aa1d3f
Submitter: Zuul
Branch: stable/queens

commit 3fa8a646e174fe1e422f7a7127b3efe2e8aa1d3f
Author: Lucian Petrut <email address hidden>
Date: Fri Jan 11 13:38:35 2019 +0200

    Avoid using 'truncate' on Windows

    The Windows SMB driver has been broken by a recent change [1],
    which is attempting to handle info file permissions, using the
    'truncate' command along the way, which is not available on Windows.

    We're not handling file permissions on Windows, so we can just skip
    this step, avoiding this issue.

    Change-Id: I1f92cef19cd2eed7ba845210f7ff89d88ba78f49
    Closes-Bug: #1811369
    (cherry picked from commit 133617828c37db78bcc71c5106c90818e0bebc3c)
    (cherry picked from commit 8230238365f5a8b356d1b0af614a62d37aab21d3)
    Conflicts:
     cinder/tests/unit/volume/drivers/test_remotefs.py

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 14.0.0.0rc1

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.6

This issue was fixed in the openstack/cinder 12.0.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/647653

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/pike)

Reviewed: https://review.openstack.org/647653
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4d795e5a32ebe0d7ab649c7419f902130dd125f0
Submitter: Zuul
Branch: stable/pike

commit 4d795e5a32ebe0d7ab649c7419f902130dd125f0
Author: Lucian Petrut <email address hidden>
Date: Fri Jan 11 13:38:35 2019 +0200

    Avoid using 'truncate' on Windows

    The Windows SMB driver has been broken by a recent change [1],
    which is attempting to handle info file permissions, using the
    'truncate' command along the way, which is not available on Windows.

    We're not handling file permissions on Windows, so we can just skip
    this step, avoiding this issue.

    Change-Id: I1f92cef19cd2eed7ba845210f7ff89d88ba78f49
    Closes-Bug: #1811369
    (cherry picked from commit 133617828c37db78bcc71c5106c90818e0bebc3c)
    (cherry picked from commit 8230238365f5a8b356d1b0af614a62d37aab21d3)
    Conflicts:
     cinder/tests/unit/volume/drivers/test_remotefs.py

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 11.2.2

This issue was fixed in the openstack/cinder 11.2.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.