multiple bugs around vendor-data

[Junien F]

Using the 18.11 charms on Ubuntu 18.04 with openstack queens.

The "vendor-data" config option is unusable.

1. It creates an invalid nova.conf - this is hitting both nova-cloud-controller and neutron-gateway (by the means of nova-metadata) :

2019-01-08 14:23:16.589 1967177 ERROR nova ConfigFileValueError: Value for option vendordata_providers is not valid: Valid values are [StaticJSON, DynamicJSON], but found "['StaticJSON']"

This is solved by transforming ctxt['vendordata_providers'] into a string, ie :

ctxt['vendordata_providers'] = ','.join(ctxt['vendordata_providers'])

2. The description of the "vendor-data" config option states that "for deployment of queens or later", it should be set in the nova-cloud-controller charm. However, the code that tests this tests for "rocky or later", ie :

in neutron-gateway : "if cmp_os_release < 'rocky':"
in nova-cloud-controller : "if cmp_os_release >= 'rocky':"

so the description should be updated to state "rocky" and not "queens" as the limit.

Thanks

[Tom Haddon (mthaddon)]

See https://review.openstack.org/#/c/629412/ for changes addressing this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/638618

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/638618
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=d746152fb86c2fa8cf39d1bd4b29ca0f3896393f
Submitter: Zuul
Branch: master

commit d746152fb86c2fa8cf39d1bd4b29ca0f3896393f
Author: James Page <email address hidden>
Date: Fri Feb 22 10:17:05 2019 +0000

    Fix formatting of vendordata_providers config

    Align formatting of vendordata_providers configuration for nova
    with changes in neutron-gateway; values must be strings, delimited
    by a comma.

    Change-Id: I5293edd77387347f8c012521f4bdeffadc919438
    Closes-Bug: 1810953

[Wouter van Bommel (woutervb)]

This problem also happens on xenial, running Queens.

[Xav Paice (xavpaice)]

I've reset this to new, because although the patch may fix this issue for Rocky, we still have the same error in Queens because of the charm test on L451 of nova_cc_context.py:

if cmp_os_release >= 'rocky':

Unfortunately, if we're running Queens or below there's no vendordata support at all as a result of this.

[Felipe Reyes (freyes)]

These config options are available since newton[0] and it was queens only that removed support[1]

[0] https://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/vendordata-reboot.html
[1] https://github.com/openstack/nova/blob/stable%2Fqueens/releasenotes/notes/remove-deprecated-vendordata_driver-opt-3ececc051e581070.yaml

[Felipe Reyes (freyes)]

I will be testing newton to make sure things work as I expect before proposing a patch

[James Hilling (jamesh5979)]

This is currently affecting at least one customer in production running Queens. Is it possible to get this backported soon?

[Chris MacNaughton (chris.macnaughton)]

The openstack-charms release has moved forward with the release of 19.04. According to the comments above, the given fix will NOT resolve the issue on Queens anyway and requires further work

[Junien F (axino)]

You need to configure vendordata on *neutron-gateway* for queens and below. The patch mentioned in the first comment fixes neutron-gateway.

[Chris MacNaughton (chris.macnaughton)]

My bad, the fix to neutron-gateway wasn't correctly tagged on here but was resolved in https://review.openstack.org/#/c/629412/

[Chris MacNaughton (chris.macnaughton)]

From talking to Junien, it is my understanding that for releases prior to Rocky, the fix in neutron-gateway resolves this issue