fedora tripleo-ci-testing link creation fails

[wes hayutin]

2019-01-07 22:46:18.660306 | TASK [Promote consistent to tripleo-ci-testing for fedora repo if an equivalent exists]
2019-01-07 22:46:19.178384 | rdo-centos-7 | MODULE FAILURE
2019-01-07 22:46:19.190401 |
2019-01-07 22:46:19.190526 | PLAY RECAP
2019-01-07 22:46:19.190604 | rdo-centos-7 | ok: 3 changed: 3 unreachable: 0 failed: 1

https://logs.rdoproject.org/openstack-periodic/git.openstack.org/openstack-infra/tripleo-ci/master/periodic-tripleo-centos-7-master-promote-consistent-to-tripleo-ci-testing/e7104cf/job-output.txt.gz#_2019-01-07_22_46_18_660306

This is a promotion blocker

[wes hayutin (weshayutin)]

Failed here, w/o much detail
https://github.com/rdo-infra/review.rdoproject.org-config/blob/master/playbooks/tripleo-ci-base-promote-consistent-to-tripleo-ci-testing/run.yaml#L33

[wes hayutin (weshayutin)]

https://review.rdoproject.org/r/#/c/17744/ was the change the broke promotions if we need to revert.

[yatin (yatinkarel)]

<< https://review.rdoproject.org/r/#/c/17744/ was the change the broke promotions if we need to revert.

Reverted https://review.rdoproject.org/r/#/c/18104/ in order to run promotion jobs until the issue is fixed.

[Gabriele Cerami (gcerami)]

Found the bug, dlrnapi command has a typo ... repo_status instead of repo-status

[Gabriele Cerami (gcerami)]

https://review.rdoproject.org/r/18122 was merged as fix, not sure if the promotion jobs will be unblocked completely after this

[Gabriele Cerami (gcerami)]

Thanks to jpena, we can see the error that fails the module is

'An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ValueError: No closing quotation'

ValueError: No closing quotation is an error thrown by shlex python module when a quote in a shell string to be escaped is not matched.
The only unmatched quotes we have are apostrophes in comments. Tried removing those, hope the problem is solved.

I cannot reproduce the error locally, a shlex.split of the shell module command works perfectly with the version of shlex I'm using, with or without single quotes in comments

[Gabriele Cerami (gcerami)]

In my local test I was putting an even number of single quotes in the string. As soon as I used a single single quote, the error showed up. I think we should have fixed this now ... let's check the next periodic run

[Gabriele Cerami (gcerami)]

The module now works.