Database org_top() function upgrade script errors

[Bill Erickson]

Related to bug #1730726 (PG 10 support)

PSQL complains when running 1140.function.non-set-returning-evergreen.org_top.sql:

ERROR: cannot change return type of existing function
HINT: Use DROP FUNCTION org_top() first.
ERROR: syntax error at or near ":"
LINE 1: COMMIT:
              ^
ERROR: current transaction is aborted, commands ignored until end of transaction block

[Bill Erickson (berick)]

Fix to upgrade script pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1810802-org-top-sql-upgrade-fix

[Bill Erickson (berick)]

To test:

1. Check out an older Evergreen revision (e.g. 64607a86) and build a new database.
2. Upgrade the database using the SQL upgrade scripts.
3. Before patching, the upgrade should fail with the errors noted above.

[Jason Stephenson (jstephenson)]

Good catch, Bill!

I swear I tested that upgrade script, but I guess not.

I have verified the upgrade script is broken in the manner described, and tested that Bill's fix actually resolves the two issues.

I have signed off and pushed the fix to master.