typo in ansible module name in "upgrade_tasks" of octavia*

[Pratik Pravin Bandarkar]

Description:
`openstack overcloud upgrade run --stack lab1 --nodes Controller` fails with following error:
<snip>
=> {"failed": true, "reason": "no action detected in task. This often indicates a misspelled module name, or incorrect module path.\n\nThe error appears to have been in '/var/lib/mistral/023f145b-7f46-42b6-8ae5-b50b08c20054/Controller/upgrade_tasks.yaml': line 769, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n - common: systemctl is-enabled --quiet openstack-octavia-health-manager\n ^ here\n\n\nThe error appears to have been in '/var/lib/mistral/023f145b-7f46-42b6-8ae5-b50b08c20054/Controller/upgrade_tasks.yaml': line 769, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.

[...]
=> {"failed": true, "reason": "no action detected in task. This often indicates a misspelled module name, or incorrect module path.\n\nThe error appears to have been in '/var/lib/mistral/95b865dd-4956-4704-bda8-6ac5805f7a4e/Controller/upgrade_tasks.yaml': line 784, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n - common: systemctl is-enabled --quiet openstack-octavia-housekeeping\n ^ here\n\n\nThe error appears to have been in '/var/lib/mistral/95b865dd-4956-4704-bda8-6ac5805f7a4e/Controller/upgrade_tasks.yaml': line 784, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.

[...]
=> {"failed": true, "reason": "no action detected in task. This often indicates a misspelled module name, or incorrect module path.\n\nThe error appears to have been in '/var/lib/mistral/548cb73b-c5bb-46f1-89b7-f4a90559cb12/Controller/upgrade_tasks.yaml': line 800, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n - common: systemctl is-enabled --quiet openstack-octavia-worker\n ^ here\n\n\nThe error appears to have been in '/var/lib/mistral/548cb73b-c5bb-46f1-89b7-f4a90559cb12/Controller/upgrade_tasks.yaml': line 800, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.
</snip>

The reason behind above failure is the typo in ansible module:

docker/services/octavia-worker.yaml
[...]
      upgrade_tasks:
        - when: step|int == 0
          tags: common
          block:
            - name: Check if octavia_worker is deployed
              common: systemctl is-enabled --quiet openstack-octavia-worker
              ignore_errors: True
              register: octavia_worker_enabled_result
[...]

docker/services/octavia-health-manager.yaml
[...]
      upgrade_tasks:
        - when: step|int == 0
          tags: common
          block:
            - name: Check if octavia_health_manager is deployed
              common: systemctl is-enabled --quiet openstack-octavia-health-manager
              ignore_errors: True
              register: octavia_health_enabled_result
[...]

docker/services/octavia-housekeeping.yaml
[...]
      upgrade_tasks:
        - when: step|int == 0
          tags: common
          block:
            - name: Check if octavia_housekeeping is deployed
              common: systemctl is-enabled --quiet openstack-octavia-housekeeping
              ignore_errors: True
              register: octavia_housekeeping_enabled_result
[...]

After fixing the typo("common" with "command"), the command(`openstack overcloud upgrade run`) was successful.

Environment:
- Pike
- Queens
- Rocky

Steps to reproduce:
- Deploy Pike/Queens with Octavia
- Try to upgrade the environment to Queens/Rocky

Expected Result: `openstack overcloud upgrade run` should be successful

Actual Result: `openstack overcloud upgrade run` fails

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.4.0 release.