static wired conn. doesn't write /etc/resolv.conf

[Troy Cauble]

Version 1.4.1. Kubuntu Gutsy.

Using a static wired connection, wicd *still* doesn't write /etc/resolv.conf.
It's been many releases since this worked.

[Troy Cauble (troycauble)]

In the log I see

2008/01/07 10:07:49 :: Use static DNS: True
2008/01/07 10:07:49 :: Use global DNS: None

This is printed just before the associated code does a lot of True/False checks.
Does False == None in python?

-troy

[Troy Cauble (troycauble)]

Also the related code is testing strings against booleans.

I changed

            if (network.get('use_static_dns') == True and
                network.get('use_global_dns') == False):

to

            if (bool(network.get('use_static_dns')) == True and
                bool(network.get('use_global_dns')) == False):

for one block and got the block to execute.
Or you could use "True" and "False" with quotes.

[Dan O'Reilly (oreilldf)]

Thanks for the report and fix. Would you mind changing the lines you changed back, and add these two lines to the ReadWiredNetworkProfile method:
            profile['use_global_dns'] = bool(profile['use_global_dns'])
            profile['use_static_dns'] = bool(profile['use_static_dns'])
So that it looks like this:
        if config.has_section(profilename) == True:
            for x in config.options(profilename):
                profile[x] = misc.Noneify(config.get(profilename,x))
            profile['use_global_dns'] = bool(profile['use_global_dns'])
            profile['use_static_dns'] = bool(profile['use_static_dns'])
            self.WiredNetwork = profile

Then restart everything and see if it still writes to /etc/resolv.conf? It should have the same effect as your change, it just does it right when the profile gets read into memory.

Also, yes, as you probably noticed, bool(None) == False in python.

[Troy Cauble (troycauble)]

I had to change your lines to use 'profile.get'.

            profile['use_global_dns'] = bool(profile.get('use_global_dns'))
            profile['use_static_dns'] = bool(profile.get('use_static_dns'))

I was seeing exceptions when those keys didn't exist.

-troy

[Troy Cauble (troycauble)]

(Then everything worked.)

[phys_user (myemail-slopsbox)]

Same problem here, cabled does not write the /etc/resolv.conf. Debian lenny amd64, wicd 1.4.1.