Parent zone can be deleted when child is in another tenant

[Dmitry Galkin]

Hi,

The title says its all.

In the same tenant one cannot delete the parent zone as long as it has child zones.
But when the parent zone is transferred to another tenant and deleted... you can delete it in another tenant.
(And further attempt to re-create it in another tenant will fail.)

The delete logic should look up the child zones now only in current tenant, but everywhere.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/627539

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/627539
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=9a20caa33682bafdb71398665974e7fa32dfb75d
Submitter: Zuul
Branch: master

commit 9a20caa33682bafdb71398665974e7fa32dfb75d
Author: Dmitry Galkin <email address hidden>
Date: Thu Dec 27 15:11:16 2018 +0000

    Fix the child search logic during zone deletion.

    This patch uses elevated context to look up the child zones
    when a (parent) zone is deleted. If policy allows deleting a
    zone with non-admin role - the search will not find the child
    zones in another tenant and therefore parent zone gets deleted.

    Change-Id: Id1a8228f287a8f8e02462017cd062607ff4bebf8
    Closes-Bug: 1809906

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/designate 8.0.0.0rc1 release candidate.