undercloud-upgrades: The conditional check 'step|int = 3'

[Jose Luis Franco]

A typo in this patch https://review.openstack.org/#/c/622969/ is causing the undercloud upgrades to fail:

2018-12-18 10:17:50 | TASK [Install docker packages on upgrade if missing] ***************************
2018-12-18 10:17:50 | fatal: [centos-7-rax-dfw-0001254559]: FAILED! => {"msg": "The conditional check 'step|int = 3' failed. The error was: template error while templating string: expected token 'end of statement block', got '='. String: {% if step|int = 3 %} True {% else %} False {% endif %}\n\nThe error appears to have been in '/home/zuul/undercloud-ansible-5FyMOy/Undercloud/upgrade_tasks.yaml': line 2, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n - name: Install docker packages on upgrade if missing\n ^ here\n"}
2018-12-18 10:17:50 |
2018-12-18 10:17:50 | NO MORE HOSTS LEFT *************************************************************
2018-12-18 10:17:50 |
2018-12-18 10:17:50 | PLAY RECAP *********************************************************************
2018-12-18 10:17:50 | centos-7-rax-dfw-0001254559 : ok=7 changed=0 unreachable=0 failed=1
2018-12-18 10:17:50 |
2018-12-18 10:17:50 | Exception: Upgrade failed
2018-12-18 10:17:50 | Traceback (most recent call last):
2018-12-18 10:17:50 | File "/usr/lib/python2.7/site-packages/tripleoclient/v1/tripleo_deploy.py", line 1223, in _standalone_deploy
2018-12-18 10:17:50 | raise exceptions.DeploymentError('Upgrade failed')
2018-12-18 10:17:50 | DeploymentError: Upgrade failed
2018-12-18 10:17:50 | None
2018-12-18 10:17:52 | Not cleaning working directory /home/zuul/tripleo-heat-installer-templates
2018-12-18 10:17:53 | Not cleaning ansible directory /home/zuul/un

http://logs.openstack.org/89/625589/2/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/00ddcc0/logs/undercloud/home/zuul/undercloud_upgrade.log.txt.gz#_2018-12-18_10_17_50

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/625903
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8b72e4dac0fed45ed6e6f87574d500e8db816fdf
Submitter: Zuul
Branch: master

commit 8b72e4dac0fed45ed6e6f87574d500e8db816fdf
Author: Jose Luis Franco Arza <email address hidden>
Date: Tue Dec 18 13:49:49 2018 +0100

    Fix issue with when statement in docker-registry.yaml.

    The when statement was duplicated in the docker-registry
    service, plus the equals operator was wrong.

    Closes-Bug:#1808974
    Change-Id: I1650acfd67b87be18ab03385ce35cccdf708f046

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/625821
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=033e6f70811f4c5552fb814a2a9cb805110fb8cc
Submitter: Zuul
Branch: stable/rocky

commit 033e6f70811f4c5552fb814a2a9cb805110fb8cc
Author: Jose Luis Franco Arza <email address hidden>
Date: Wed Dec 5 15:09:07 2018 +0100

    Perform docker reconfiguration on upgrade_tasks.

    The container-registry role is idempotent in a way that the
    restarting of the docker service will be done only if some
    configuration value has changed.
    During the upgrade, host_prep_tasks are being run and if the
    new templates bring some configuration change then the Docker
    service gets restarted. The issue is the point at which they
    get restarted, which is after the upgrade_tasks have already
    run and prior to the deploy_tasks. This is causing issues with
    Pacemaker handled resources.

    For that reason, we include the very same task running in host_prep_tasks
    into upgrade_tasks for the docker and docker-registry services,
    forcing the Docker service reconfiguration to happen during
    upgrade_tasks instead of at a latter point.

    This patch also fixes the typo included in the master branch patch
    I5e6ca987c01ff72a3c7e8900f9572024521164de that caused LP#1808974.

    Closes-Bug: #1807418
    Related-Bug: #1808974
    Change-Id: I5e6ca987c01ff72a3c7e8900f9572024521164de
    (cherry picked from commit 5bc5ae944a32d5c24090a4c5f5e44c64c2879c1a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.3.0 release.