rhel-registration not working due to wrong absolute path

[Jose Luis Franco]

When performing a deployment using rhel-registration SoftwareDeployment to register the nodes viah rhsm an error is occurring:

    clean_up DeployOvercloud: Action tripleo.parameters.update execution failed: 400 Client Error: Bad Request for url: https://192.168.24.2:13808/usr/share/openstack-tripleo-heat-templates/extraconfig/pre_deploy/rhel-registration/scripts/rhel-unregistration
    Traceback (most recent call last):
      File "/usr/lib/python2.7/site-packages/osc_lib/shell.py", line 134, in run
        ret_val = super(OpenStackShell, self).run(argv)
      File "/usr/lib/python2.7/site-packages/cliff/app.py", line 279, in run
        result = self.run_subcommand(remainder)
      File "/usr/lib/python2.7/site-packages/osc_lib/shell.py", line 169, in run_subcommand
        ret_value = super(OpenStackShell, self).run_subcommand(argv)
      File "/usr/lib/python2.7/site-packages/cliff/app.py", line 400, in run_subcommand
        result = cmd.run(parsed_args)
      File "/usr/lib/python2.7/site-packages/tripleoclient/command.py", line 25, in run
        super(Command, self).run(parsed_args)
      File "/usr/lib/python2.7/site-packages/osc_lib/command/command.py", line 41, in run
        return super(Command, self).run(parsed_args)
      File "/usr/lib/python2.7/site-packages/cliff/command.py", line 184, in run
        return_code = self.take_action(parsed_args) or 0
      File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 973, in take_action
        self._deploy_tripleo_heat_templates_tmpdir(stack, parsed_args)
      File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 428, in _deploy_tripleo_heat_templates_tmpdir
        new_tht_root, tht_root)
      File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 521, in _deploy_tripleo_heat_templates
        parsed_args.plan_environment_file)
      File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 536, in _try_overcloud_deploy_with_compat_yaml
        plan_env_file)
      File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 285, in _heat_deploy
        stack_name, env, moved_files, tht_root)
      File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 361, in _process_and_upload_environment
        parameters=params)
      File "/usr/lib/python2.7/site-packages/tripleoclient/workflows/parameters.py", line 20, in update_parameters
        **input_)
      File "/usr/lib/python2.7/site-packages/tripleoclient/workflows/base.py", line 31, in call_action
        raise exceptions.WorkflowActionError(action, output)
    WorkflowActionError: Action tripleo.parameters.update execution failed: 400 Client Error: Bad Request for url: https://192.168.24.2:13808/usr/share/openstack-tripleo-heat-templates/extraconfig/pre_deploy/rhel-registration/scripts/rhel-unregistration

    END return value: 1

This seems to be caused by this patch:

https://review.openstack.org/#/c/609456/1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/625877

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/625877
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1baecc6b5b82df1b822ecda038e52e2c4d6052ab
Submitter: Zuul
Branch: stable/queens

commit 1baecc6b5b82df1b822ecda038e52e2c4d6052ab
Author: Jose Luis Franco <email address hidden>
Date: Tue Dec 18 10:57:01 2018 +0000

    Revert "[Ocata/Pike/Queens] Make rhel-registration scripts location absolute."

    This reverts commit 91746c290be5fc374ad2389694779a7b57351c81.
    The patch is causing issues when deploying TripleO using rhel-registration scripts.

    Change-Id: Iefb47eaf307f942b10de59fd95821e9bdc0b7e19
    Closes-Bug:#1808965

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/629100

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/629100
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b6b01d5c247e6d6ed4a128a380114a393dcd2e29
Submitter: Zuul
Branch: stable/pike

commit b6b01d5c247e6d6ed4a128a380114a393dcd2e29
Author: Jose Luis Franco <email address hidden>
Date: Tue Dec 18 10:57:01 2018 +0000

    Revert "[Ocata/Pike/Queens] Make rhel-registration scripts location absolute."

    This reverts commit 91746c290be5fc374ad2389694779a7b57351c81.
    The patch is causing issues when deploying TripleO using rhel-registration scripts.

    Change-Id: Iefb47eaf307f942b10de59fd95821e9bdc0b7e19
    Closes-Bug:#1808965
    (cherry picked from commit 1baecc6b5b82df1b822ecda038e52e2c4d6052ab)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.3.0 release.

[Nebu Mathews (nebupm)]

Is this going to be backported to Queens?

[Jose Luis Franco (jfrancoa)]

It got already merged in pike and queens too: https://review.openstack.org/#/c/625877/ (queens) and https://review.openstack.org/#/c/629100/ (pike)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.18 release.