puppet-tripleo lint job failure

[Alex Schultz]

https://review.openstack.org/#/c/624989/ fixed the puppet lint job but unfortunately puppet-tripleo has some linting problems in master which is now blocking the gate

manifests/certmonger/ca/crl.pp:110:WARNING: arrow should be on the right operand's line
manifests/certmonger/qemu.pp:72:WARNING: top-scope variable being used without an explicit namespace
manifests/profile/base/cinder/volume/rbd.pp:62:WARNING: missing documentation for class parameter tripleo::profile::base::cinder::volume::rbd::::hostname
manifests/profile/base/neutron.pp:121:WARNING: double quoted string containing no variables
manifests/profile/base/neutron.pp:118:WARNING: variable not enclosed in {}
manifests/profile/base/neutron/dhcp_agent_wrappers.pp:72:WARNING: double quoted string containing no variables
manifests/profile/base/neutron/l3_agent_wrappers.pp:112:WARNING: double quoted string containing no variables
manifests/profile/base/neutron/ovn_metadata_agent_wrappers.pp:55:WARNING: double quoted string containing no variables
manifests/profile/base/neutron/wrappers/dibbler_client.pp:40:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/dibbler_client.pp:41:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/dibbler_client.pp:44:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/dibbler_client.pp:45:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/dibbler_client.pp:46:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/dnsmasq.pp:40:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/dnsmasq.pp:41:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/dnsmasq.pp:44:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/dnsmasq.pp:45:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/dnsmasq.pp:46:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/haproxy.pp:40:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/haproxy.pp:41:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/haproxy.pp:44:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/haproxy.pp:45:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/haproxy.pp:46:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/keepalived.pp:40:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/keepalived.pp:41:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/keepalived.pp:44:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 27)
manifests/profile/base/neutron/wrappers/keepalived.pp:45:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 27)
manifests/profile/base/neutron/wrappers/keepalived.pp:46:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 27)
manifests/profile/base/neutron/wrappers/keepalived_state_change.pp:36:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/keepalived_state_change.pp:37:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/keepalived_state_change.pp:40:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/keepalived_state_change.pp:41:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/keepalived_state_change.pp:42:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 25)
manifests/profile/base/neutron/wrappers/radvd.pp:41:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/radvd.pp:42:WARNING: optional parameter listed before required parameter
manifests/profile/base/neutron/wrappers/radvd.pp:45:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 27)
manifests/profile/base/neutron/wrappers/radvd.pp:46:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 27)
manifests/profile/base/neutron/wrappers/radvd.pp:47:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 27)
manifests/profile/base/tuned.pp:29:WARNING: ensure found on line but it's not the first attribute
manifests/profile/base/tuned.pp:26:WARNING: arrow should be on the right operand's line
manifests/profile/base/tuned.pp:28:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 14)
manifests/profile/base/tuned.pp:30:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 14)
manifests/profile/base/tuned.pp:31:WARNING: indentation of => is not properly aligned (expected in column 15, but found it in column 14)
manifests/ui.pp:172:WARNING: indentation of => is not properly aligned (expected in column 16, but found it in column 22)
manifests/ui.pp:173:WARNING: indentation of => is not properly aligned (expected in column 16, but found it in column 22)
manifests/ui.pp:174:WARNING: indentation of => is not properly aligned (expected in column 16, but found it in column 22)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/625737

[Sorin Sbarnea (ssbarnea)]

There are multiple repositories affected by the release of ansible-lint but here is a better wayt o fix it https://review.openstack.org/#/c/625997/ -- this change is on tripleo-upgrades and matches what we already had on tripleo-quickstart-extra which cannot be hit by such surprises.

[Alex Schultz (alex-schultz)]

@sorin, wrong bug as this is the puppet-lint bug

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/625737
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=daa4710a0ae1df775da6c4ad736762a7c4016a21
Submitter: Zuul
Branch: master

commit daa4710a0ae1df775da6c4ad736762a7c4016a21
Author: Alex Schultz <email address hidden>
Date: Mon Dec 17 17:00:33 2018 -0700

    Fix linting issues

    https://review.openstack.org/624989 fixed the lint job and since it's
    been broken for a while, we've got some linting issues.

    Closes-Bug: #1808883
    Change-Id: I3d5df4479cf05f4c4a81d37184e8225ea1478e26

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 10.2.0 release.