When upgrading frm osp13 to osp14 having an already registered overcloud via Satellite (old rhel-registration service was used during deployment) the overcloud upgrade run command will fail because it can't find some puppet classes. This is usually a sign that the overcloud nodes did not have their repositories updated to the last version.
This can be observed in the upgrade_tasks when rhsm service invokes redhat-subsciption ansible role:
u'TASK [redhat-subscription : SATELLITE 6 | Install katello-ca-consumer] *********',
u'Tuesday 11 December 2018 07:15:18 -0500 (0:00:00.916) 0:01:05.081 ****** ',
u'ok: [controller-0] => {"changed": false, "msg": "", "rc": 0, "results": ["katello-ca-consumer-rhos-compute-node-08.lab.eng.rdu2.redhat.com-1.0-2.noarch providing /tmp/katello-ca-consumer-latest.noarchK641hh.rpm is already installed"]}',
u'',
u'TASK [redhat-subscription : SATELLITE 6 | Execute katello-rhsm-consumer] *******',
u'Tuesday 11 December 2018 07:15:23 -0500 (0:00:05.216) 0:01:10.298 ****** ',
u'skipping: [controller-0] => {"changed": false, "skip_reason": "Conditional result was False"}',
u'',
u'TASK [redhat-subscription : Manage Red Hat subscription] ***********************',
u'Tuesday 11 December 2018 07:15:24 -0500 (0:00:00.392) 0:01:10.690 ****** ',
u'ok: [controller-0] => {"changed": false, "msg": "System already registered."}',
u'',
u'TASK [redhat-subscription : Configure repository subscriptions] ****************',
u'Tuesday 11 December 2018 07:15:26 -0500 (0:00:01.948) 0:01:12.639 ****** ',
u'skipping: [controller-0] => {"changed": false, "skip_reason": "Conditional result was False"}',
u'',
u'TASK [Check if swift-proxy or swift-object-expirer are deployed] ***************',
u'Tuesday 11 December 2018 07:15:26 -0500 (0:00:00.285) 0:01:12.924 ****** ',
The role does not register the environment with the new osp14 activation key provided because the system was already registered.
Fix proposed to branch: master
Review: https:/