The angular fmeditor does not associate its label and input tags

[Jane Sandberg]

Associating labels and inputs is important for accessibility. Branch forthcoming.

[Jane Sandberg (sandbergja)]

I created a branch to fix this called user/sandbergja/lp1807523_angular_fmeditor_labels_inputs

Here's a link: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1807523_angular_fmeditor_labels_inputs

[Bill Erickson (berick)]

Thanks for the bug/patch, Jane! I eyeballed the patch and it will certainly get the job done. However, I'm hesitant to apply predictable DOM ID's to components where multiple instances could be active in a single page, since the possibility exists for ID's to get clobbered. (Not terribly likely in this case, but certainly possible).

Perhaps we could teach FmEditorComponent to add a bit of randomness to its field IDs. E.g.

TS
ngOnInit() {
  ...
  this.domId = 'fm-editor-' + Math.random();
}

HTML
<input id='{{this.domId}}-{{field-name}}' ... />

[Jane Sandberg (sandbergja)]

Good idea, Bill. I added a follow up commit to that branch to add a bit of randomness to the IDs that are generated.

[Bill Erickson (berick)]

Looks great, thanks Jane! Merged to master and 3.2.