Search terms not carried correctly when placing holds

[Michele Morgan]

Evergreen 3.2

When a user clicks on a Place Hold link in the opac, the search terms box is blank rather than being populated with the terms of the original search. This happens regardless of whether the search was Basic or Advanced, and regardless of whether the Place hold link was clicked from the search results or full record page.

A previous related bug that was fixed for 3.1.2 is:

https://bugs.launchpad.net/evergreen/+bug/1732591

This fix left a remaining issue in 3.1.2 when the library settings opac.patron.jump_to_details_on_single_hit/opac.patron.jump_to_details_on_single_hit were set to TRUE. In that case the ARRAY... error still appeared when clicking Place Hold from an Advanced search which resulted in one hit and the full record was displayed as a result.

In 3.2, we do not see any ARRAY... errors, but we are seeing that search terms are never carried to the Place Hold screen. If the user proceeds to place the hold and clicks Continue, the search terms return to the search box. Likewise, if the user cancels, the search terms return to the search box.

I suspect this change in behavior was introduced by bug 1721575.

To reproduce:

Login to the opac
Perform a search
Click Place Hold - note that the search box is blank
Click Submit - note that the search box is blank
Click Continue - note that the search box has been repopulated with the user's search terms

The fix for this should address the use case where a search results in a single hit and jumps to the full record when the library settings opac.patron.jump_to_details_on_single_hit/opac.staff.jump_to_details_on_single_hit are set to TRUE.