AddressSanitizer: heap-use-after-free

[Steven De Herdt]

AddressSanitizer gave me a heap-use-after-free in ../src/wui/buildingwindow.cc:359 in operator() - see attached log.
I don't quite understand what's going on, is this actually a bug in Widelands or rather in Boost or something? I'm using Debian testing.

[GunChleoc (gunchleoc)]

Do you still remember what you were doing when this occurred? Looks like you opened a window, which one?

[GunChleoc (gunchleoc)]

I could not reproduce this, so the fix in the attached branch is just a guess.

[kaputtnik (franku)]

Since this bug is not reproducible, can't we retarget it to build21?

[GunChleoc (gunchleoc)]

Any objections to merging the attached branch and closing this?

[hessenfarmer (stephan-lutz)]

In my opinion a bug that isn't reproducible should be considered spurious therefore I would vote for postponing this and see whether we will get any new issues of that. If it is hard to reproduce the Chance of occuring is rather remote and therefore no showstopper.

Although the Change you suggested should not do any harm.

So from my side feel free to either merge or postpone it. Perhaps asking Klaus via PM if he found something else might be an idea.

[GunChleoc (gunchleoc)]

Let's merge it and postpone the bug then.

[Steven De Herdt (stdh)]

A late reply: I no longer have any idea what I was doing that might have triggered this. If no one can reproduce this bug, and you may have solved it anyway, maybe you should just close this report?

[GunChleoc (gunchleoc)]

I have set it to incomplete, that should make it disappear from the list after a while.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]