overcloud image is missing ansible-role-redhat-subscription RPM

[Emilien Macchi]

In Queens, we introduced host_prep_tasks, which are running Ansible in localhost mode, using OS::Heat::SoftwareConfig.

Which means the roles used by these tasks need to be on the Overcloud if the service is deployed on the Overcloud. Like it's the case for Rhsm service.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/623085

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/624094

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/623085
Reason: https://review.openstack.org/624094

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/624094
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=d4169671213706d97049c652ecc72571e08979db
Submitter: Zuul
Branch: stable/queens

commit d4169671213706d97049c652ecc72571e08979db
Author: Emilien Macchi <email address hidden>
Date: Wed Dec 5 17:17:41 2018 -0500

    [queens-only] include ansible-role-redhat-subscription in base image

    In queens, Ansible runs some tasks on localhost (overcloud nodes) so
    ansible-role-redhat-subscription rpm is needed on the overcloud images
    when we will run Ansible to unsubscribe the nodes on the overcloud.

    Change-Id: I18e2bde1e20a9eb1840b237b840b407ecf1641cd
    Closes-Bug: #1807025

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-puppet-elements 8.0.2 release.