update.sh deletes files when there is no new version
Bug #1806901 reported by
GunChleoc
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
https:/
Running update.sh twice in a row will delete the executables without providing any new ones.
Tested with bzr 8937.
Related branches
lp:~widelands-dev/widelands/bug-1806901_use_compile_sh_in_update_sh
- GunChleoc: Approve
-
Diff: 27 lines (+3/-7)1 file modifiedcompile.sh (+3/-7)
Revision history for this message
| kaputtnik (franku) wrote | #1 |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #2 |
| Changed in widelands: | |
| status: | New → Fix Committed |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #3 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I can't confirm this for a fresh branch.
But i think what is going on here: The update script will not be regenerated if you call it. If this script was made with a version prior r8907 (cp VERSION file), it will contain 'mv VERSION ..' and thus fails if running twice.
The solution is either to run compile.sh again, which regenerates update.sh, or replace 'mv VERSION ../VERSION' with 'cp VERSION ../VERSION' inside update.sh.
Maybe better is to call compile.sh from update.sh. This will run cmake again, so needs more time, but maybe it also better to configure the project again if some third party packages are updated?
IMHO using one compile logic is better than maintaining two parts.