Bug #1806719 “Build dependencies are not checked in SConscripts ...” : Bugs : OpenContrail

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-04: [Review update] master

#1

Review in progress for https://review.opencontrail.org/48014
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-04:

#2

Review in progress for https://review.opencontrail.org/48015
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-05:

#4

Review in progress for https://review.opencontrail.org/48027
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-14: A change has been merged

#6

Reviewed: https://review.opencontrail.org/48014
Committed: http://github.com/Juniper/contrail-build/commit/cc2bf7bae3453d0e513bb8e58e3f308173bfd105
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit cc2bf7bae3453d0e513bb8e58e3f308173bfd105
Author: Mateusz Jablonski <email address hidden>
Date: Tue Dec 4 17:19:08 2018 +0100

Register a method for checking build dependencies from SConscripts

Change-Id: I1d172e7dd489fa8cbbd12466617556675dcea6c1
Partial-Bug: #1806719

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-14:

#7

Reviewed: https://review.opencontrail.org/48015
Committed: http://github.com/Juniper/contrail-common/commit/a7543731153b510718394e509df8a0b293b515c6
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit a7543731153b510718394e509df8a0b293b515c6
Author: Mateusz Jablonski <email address hidden>
Date: Tue Dec 4 17:22:28 2018 +0100

Check build dependencies for Sandesh

Change-Id: I1bcb6c028715ba1f39d98e42c57f97c0be16efe6
Depends-On: I1d172e7dd489fa8cbbd12466617556675dcea6c1
Partial-Bug: #1806719

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-12-14:

#8

Reviewed: https://review.opencontrail.org/48027
Committed: http://github.com/Juniper/contrail-controller/commit/34d2439eaace6ab70ae85c8abd64497f33828406
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 34d2439eaace6ab70ae85c8abd64497f33828406
Author: Mateusz Jablonski <email address hidden>
Date: Wed Dec 5 11:25:39 2018 +0100

Check build dependencies for tbb, SimpleAmqpClient and rabbitmq

Change-Id: Ia9e19fa49593246230ee64658cd8c006ab5c518d
Depends-On: I1bcb6c028715ba1f39d98e42c57f97c0be16efe6
Closes-Bug: #1806719

Mateusz Jablonski (mateusz.jablonski) on 2019-01-03

Changed in opencontrail:
status:	New → Fix Committed

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-02-20:

#9

Download full text (6.7 KiB)

Reviewed: https://review.opencontrail.org/49390
Committed: http://github.com/Juniper/contrail-common/commit/fe6ebdaec8e7c90d91c49ba344a59b42f452b8bd
Submitter: Vinay Vithal Mahuli (<email address hidden>)
Branch: R6.0-WIP

commit fe6ebdaec8e7c90d91c49ba344a59b42f452b8bd
Author: mkheni <email address hidden>
Date: Thu Nov 8 13:23:42 2018 -0800

Apply commits from master onto R6.0-WIP

Initliaze Sandesh Collector on given IP.
if not ip is provided, listen on 0.0.0.0
Partial-bug: #1802399

Contrail Stats to external Stats Collector
User can provide external collector (ip:port or local domain socket),
If the external collector is provided, contrail generators will
send the UVEs converted into JSON format to the external collector
in addition to the Contrail Collector.
Closes-bug: #1793204

Check build dependencies for Sandesh
Partial-Bug: #1806719

Fix compilation warnings for 'io' and 'sandesh'
- Add explicit casting where needed
- Change types
- Change friend function to templated function
- Fix whitespaces at end of lines
Partial-Bug: #1800894

Fix compilation warnings for 'base' directory
Partial-Bug: #1800894

ParseInt function should check for Uint also
Rapidjson sets the flag of type UnsingedInt if the MSB
is set. While retrieving such values, we need to check
for Uint values also.
Closes-Bug: #218680

Make sandesh and ssl talk TLSv1.2
Use SSLv23 client and server for SSL connections and disable the more vulnerable
versions thereby ensuring the communication happens only on TLSv1.2
This ensures introspect and sandesh services now use TLS v1.2
Partial-Bug: #1807296

JSON encoding of the sandesh UVE messages
This fix adds the file wihch provides implementation of
transport API's exposed. The transport API's will be called
by the generated sandesh code.
UT added for the JSON generator. Currently the validity of
the JSON was checked with online tools. Holding the
verification part until we export a JSON library to sandesh.
Code Change:
JSON encoding unlike the XML encoding uses comma seperation
for members, string values for keys and {} enclosure for
complex types. To accomodate this following data structure
were introduced:
A vector to keep track of the element we are currently encoding
and whether its a first member of the familt or not:
Here is an example:
If we are encoding a list within sandesh structure,
current_sandesh_context_ maintains the following members in its
list viz., sandesh->struct_s1->list_l1
is_first_element_list_ maintains whether we are processing first
list element or we not.If we were in the middle of the list,
the structure is_first_element_list_ will be as follows:
true->false->false
Here the first false, indicates that list is not the first
member of the struct and the second false indicates that we
are done encoding the first element of the list.
Partial-Bug: 1789312

Do not resolve 127.*.*.* ip to names
DNS reverse resolution some times can take seconds.. Most of BGP and XMPP UTs
run over 127...* addresses and run timers in milliseconds. If asynchronous IO
operations do not complete very fast, then they are teared down and new ones
are created. Hence, hard-code 127.* addresses to localhost.
Also mark an arg in se...

Reviewed:  https://review.opencontrail.org/49390
Committed: http://github.com/Juniper/contrail-common/commit/fe6ebdaec8e7c90d91c49ba344a59b42f452b8bd
Submitter: Vinay Vithal Mahuli (vmahuli@juniper.net)
Branch:    R6.0-WIP

commit fe6ebdaec8e7c90d91c49ba344a59b42f452b8bd
Author: mkheni <mkheni@juniper.net>
Date:   Thu Nov 8 13:23:42 2018 -0800

Apply commits from master onto R6.0-WIP

Initliaze Sandesh Collector on given IP.
if not ip is provided, listen on 0.0.0.0
Partial-bug: #1802399

Contrail Stats to external Stats Collector
User can provide external collector (ip:port or local domain socket),
If the external collector  is provided, contrail generators will
send the UVEs converted into JSON format to the external collector
in addition to the Contrail Collector.
Closes-bug: #1793204

Check build dependencies for Sandesh
Partial-Bug: #1806719

Fix compilation warnings for 'io' and 'sandesh'
- Add explicit casting where needed
- Change types
- Change friend function to templated function
- Fix whitespaces at end of lines
Partial-Bug: #1800894

Fix compilation warnings for 'base' directory
Partial-Bug: #1800894

ParseInt function should check for Uint also
Rapidjson sets the flag of type UnsingedInt if the MSB
is set. While retrieving such values, we need to check
for Uint values also.
Closes-Bug: #218680

Make sandesh and ssl talk TLSv1.2
Use SSLv23 client and server for SSL connections and disable the more vulnerable
versions thereby ensuring the communication happens only on TLSv1.2
This ensures introspect and sandesh services now use TLS v1.2
Partial-Bug: #1807296

JSON encoding of the sandesh UVE messages
This fix adds the file wihch provides implementation of
transport API's exposed. The transport API's will be called
by the generated sandesh code.
UT added for the JSON generator. Currently the validity of
the JSON was checked with online tools. Holding the
verification part until we export a JSON library to sandesh.
Code Change:
JSON encoding unlike the XML encoding uses comma seperation
for members, string values for keys and {} enclosure for
complex types. To accomodate this following data structure
were introduced:
A vector to keep track of the element we are currently encoding
and whether its a first member of the familt or not:
Here is an example:
If we are encoding a list within sandesh structure,
current_sandesh_context_ maintains the following members in its
list viz., sandesh->struct_s1->list_l1
is_first_element_list_ maintains whether we are processing first
list element or we not.If we were in the middle of the list,
the structure is_first_element_list_ will be as follows:
true->false->false
Here the first false, indicates that list is not the first
member of the struct and the second false indicates that we
are done encoding the first element of the list.
Partial-Bug: 1789312

Do not resolve 127.*.*.* ip to names
DNS reverse resolution some times can take seconds.. Most of BGP and XMPP UTs
run over 127...* addresses and run timers in milliseconds. If asynchronous IO
operations do not complete very fast, then they are teared down and new ones
are created. Hence, hard-code 127.* addresses to localhost.
Also mark an arg in set_sychronize() as const.
Closes Jira Bug: CBS-6

Refactor base/timer*
- Remove support for old boost (<1.49)
- Remove usage of auto_ptr
- Remove friend declarations
Partial-Bug: #1800894

Fix type conversion related warnings in base/timer*
Partial-Bug: #1800894

Fix warnings: comparison between signed and unsigned integer
Partial-Bug: #1800894

Python JSON encoding of the sandesh UVE messages
This fix adds the file wihch provides implementation of
transport API's exposed. The transport API's will be called
by the generated sandesh code.
UT added for the JSON generator. Currently the validity of
the JSON was checked with online tools. Holding the
verification part until we export a JSON library to sandesh.
Code Change:
JSON encoding unlike the XML encoding uses comma seperation
for members, string values for keys and {} enclosure for
complex types. To accomodate this following data structure
were introduced:
A vector to keep track of the element we are currently encoding
and whether its a first member of the familt or not:
Here is an example:
If we are encoding a list within sandesh structure,
current_sandesh_context_ maintains the following members in its
list viz., sandesh->struct_s1->list_l1
is_first_element_list_ maintains whether we are processing first
list element or we not.If we were in the middle of the list,
the structure is_first_element_list_ will be as follows:
true->false->false
Here the first false, indicates that list is not the first
member of the struct and the second false indicates that we
are done encoding the first element of the list.
Partial-Bug: 1789312

Support host check for SSL nova metadata
- for peer check there should be host name
is used in url
partial-jira-bug: JCB-218839

Fix warnings related to type conversion
Partial-Bug: #1800894

Use semicolons properly with 'while(false)' in macros
Partial-Bug: #1800894

HTTP  parsing logic changed
Previous parsing of the URL assumed that all the
entities will be in the same order always
but that can not always be the case.
Current fix parses the request and fills the
entity values as and when they are found in the request
DocImpact
Closes-bug: #1796870
closes-jira-bug: JCB-281081
enter the commit message for your changes. Lines starting

Use fqdn in CreateConnection for http
- it for peers verifications in SSl case with FQDNs
partial-jira-bug: JCB-218839

remove old constructor for CqlIf
this commit removes old constructor for CqlIf cause all changes
was made across all repositories and it's not needed now.
closes-jira-bug: JCB-218753

Add comment about incorrect definition of __cplusplus in MSVC
Partial-Bug: #1800894

Fix type conversion related warnings in base/task*
Partial-Bug: #1800894

Handle setting socket file as stats collector
A Core was seen when setting socket file as stats_collector
Instead of doing try...catch to figure out whether the stats_collector
is a socket file or ip,port, simply look for a ':' in the string
closes-jira-bug: JCB-218930

Partially fix formatting in sandesh/compiler/generate/*
Partial-Bug: #1800894

Contrail Stats to External Collector - Python Client
User can provide external collector (ip:port or local domain socket),
If the external collector  is provided, contrail generators will
send the UVEs converted into JSON format to the external collector
in addition to the Contrail Collector.
Closes-bug: #1793204

cpuinfo changes for windows : new windows specific code as well as refactoring
Partial-Bug: #1803774

Change-Id: Icd111bf92e4656fe7187726cd95ceabb80b9415f
Depends-on: I2a0b02bb4a29601025e1afb6a696baf031375c4b
Partial-jira-bug: JBE-925

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2019-02-20:

#11

Download full text (37.3 KiB)

Reviewed: https://review.opencontrail.org/49393
Committed: http://github.com/Juniper/contrail-controller/commit/77df3b58265b3fab414dfbc00e1ff39d19f0a99c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R6.0-WIP

commit 77df3b58265b3fab414dfbc00e1ff39d19f0a99c
Author: Shivayogi Ugaji <email address hidden>
Date: Mon Nov 5 22:07:18 2018 -0800

Apply commits from master onto R6.0-WIP

db_resync_done lock is used to indicate the amqp thread to wait for resync to
complete. In this case, when we call SchemaTransformer.destroy_instance()
due to Casandra connection failure, this lock remains locked blocking
destroy_instance. destroy_instance calls _vnc_subscribe_callback to drain the
amqp queue which waits infinitely for db_resync_done lock to be released.
This fix releases db_resync_done lock so that destroy_instance doesnt get
blocked.
Closes-Bug: #1801474

[DM] Hitless image upgrade implementation
Closes-Bug: #1799322

Provisioner for the devicemanager node.
usage:
from /opt/contrail/utils
python provision_devicemgr_node.py --host_name aio --host_ip 10.87.82.2
--oper add --admin_user admin --admin_password contrail123 --admin_tenant_name
admin --openstack_ip 10.87.82.2 --api_server_ip 10.87.82.2
Closes-Bug: #1805303

CFM: Changes for onboarding L3PNF
- Add new platform SRX240
- Add L3PNF subnet is schema
- Add new namespace, VN and IPAM for L3PNF during brownfield onboarding
Closes-Bug: 1800701

Add entrypoint to vrouter-agent service on Windows
Introduce entrypoint for agent similar in design to that from
microservice deployment. For now it will only start agent,
actual features will be added in following changes.
Partial-Bug: #1806677

Check build dependencies for tbb, SimpleAmqpClient and rabbitmq
Closes-Bug: #1806719

Make agent's entrypoint update agent's config on Windows
In future we will generate the whole config from scratch
as on Linux, but for now we only update the vhost's ifname.
It's the only field that can change upon restart.
Partial-Bug: #1806677

bgp-peer selection support for bgpaas
1. Listener BgpRouterConfig is added for BgpRouter and ControlNodeZone
2. BgpRouterConfig builds BgpRouterTree and ControlNodeZoneTree
from IFMapNode
3. BGPaaS gets BgpRouter for configured ControlNodeZone from
BgpRouterConfig and Updates bgp-peer-ip and bgp-peer-port in
the flow.
4. Step 3 is followed for xmpp based peer-selection also.
5. BGPaaS sandesh is updated with primary_control_node_zone,
secondary_control_node_zone, bgp_peer_ip and bgp_peer_port
Partial-bug: #1775872

[DM] Inside-outside workflow - lag/mH
1. Change the exisiting business logic to adhere to the new data model for lag/mH workflow
2. Multi-vlan support
Partial-Bug: #1799329

Rework nodemgr before fixing ntp issue
- move windows/linux code to separate classes instead of same condition through the code
- simplify main.py
- remove copy duplication
Closes-Bug: 1800704

[fabric] Added playbook retry support to job manager
1) When playbook return retry_devices in the output, job manager will retry the playbooks against those devices
2) remove obsolete playbooks from 5.0
3) remove obsolete ansible roles from 5.0
4) added a warning log on missing loopback interface when ...

Reviewed:  https://review.opencontrail.org/49393
Committed: http://github.com/Juniper/contrail-controller/commit/77df3b58265b3fab414dfbc00e1ff39d19f0a99c
Submitter: Zuul v3 CI (zuulv3@zuul.opencontrail.org)
Branch:    R6.0-WIP

commit 77df3b58265b3fab414dfbc00e1ff39d19f0a99c
Author: Shivayogi Ugaji <yogi@juniper.net>
Date:   Mon Nov 5 22:07:18 2018 -0800