Confusing messaging from git ubuntu build
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-ubuntu |
Triaged
|
Undecided
|
Unassigned |
Bug Description
[Impact]
When attempting to build a package with an incorrect patch file, the error messages reported by git ubuntu build don't help in diagnosing the actual problem.
[Test Case]
Make a debian patch file that modifies files inside the debian directory.
call git ubuntu build-source -v
Result:
12/04/2018 11:05:00 - DEBUG:Executing: dpkg-source --commit . git-ubuntu-
12/04/2018 11:05:02 - ERROR:Command exited 2: dpkg-source --commit . git-ubuntu-
12/04/2018 11:05:02 - ERROR:stdout: dpkg-source: info: applying xyz.patch
...
dpkg-source: info: applying modify_
patching file debian/control.in
Reversed (or previously applied) patch detected! Skipping patch.
8 out of 8 hunks ignored
dpkg-source: info: the patch has fuzz which is not allowed, or is malformed
dpkg-source: info: if patch 'modify_
12/04/2018 11:05:02 - ERROR:stderr: Can't exec "gcc": No such file or directory at /snap/git-
dpkg-source: warning: cannot determine CC system type, falling back to default (native compilation)
dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -E -b -B .pc/modify_
[Regression Potential]
This is a messaging issue, so none.
Changed in usd-importer: | |
status: | New → Triaged |
tags: | added: build |
tags: | added: quiltify |
Hmm, I'm facing a similar issue if calling 'dpkg-buildpackage -S -d' (that calls again 'dpkg-source') and having a quilt patch in place that modifies debian/* content (i.e. debian/ tests/control) .
While we commonly use quilt to modify also content below debian/* /www.debian. org/doc/ manuals/ maint-guide/ modify. en.html)
reading the following in the Debian/Ubuntu policy:
The program quilt offers a basic method for recording modifications to the upstream source for Debian packaging.
(https:/
makes me think.
Not sure if quilt is really limited for patching source code only (and no meta data, like debian/*) ?
The quilt patch I have 'pushes' and 'pops' totally fine, using quilt directly.
But just not if called by 'dpkg-buildpackage -S -d' (aka 'dpkg-source'):
$ dpkg-buildpackage -S -d patches/ series ignore- dis_syslink- messages- on-ppc64el- with-glibc- 2.33.patch 6.12.orig. tar.xz patches/ series tests/control ignore- dis_syslink- messages- on-ppc64el- with-glibc- 2.33.patch' is correctly applied by quilt, use 'quilt refresh' to update it 1916749- ignore- dis_syslink- messages- on-ppc64el- with-glibc- 2.33.patch/ --reject-file=- < plf-colony. orig.h2y_ qd/debian/ patches/ lp-1916749- ignore- dis_syslink- messages- on-ppc64el- with-glibc- 2.33.patch subprocess returned exit status 1
dpkg-buildpackage: info: source package plf-colony
dpkg-buildpackage: info: source version 6.12-1ubuntu1
dpkg-buildpackage: info: source distribution hirsute
dpkg-buildpackage: info: source changed by Frank Heimes <email address hidden>
dpkg-source --before-build .
dpkg-source: info: using patch list from debian/
dpkg-source: info: applying lp-1916749-
debian/rules clean
dh clean
dh_clean
dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building plf-colony using existing ./plf-colony_
dpkg-source: info: using patch list from debian/
patching file debian/
Reversed (or previously applied) patch detected! Skipping patch.
1 out of 1 hunk ignored
dpkg-source: info: the patch has fuzz which is not allowed, or is malformed
dpkg-source: info: if patch 'lp-1916749-
dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -E -b -B .pc/lp-
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
And there is also no reject file.