tripleo

set-libvirt-type throws a misleading failure

Bug #1806496 reported by Alex Schultz on 2018-12-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Rafael Folco	tripleo stein-2

Bug Description

We should not throw a non-fatal failure as it leads to issues with people figuring out the true failure.

http://logs.openstack.org/90/614290/2/gate/tripleo-ci-centos-7-standalone/5c77eaf/job-output.txt.gz#_2018-12-03_21_18_15_207420

2018-12-03 21:18:15.243064 | primary | Monday 03 December 2018 21:18:15 +0000 (0:00:00.125) 0:08:57.208 *******
2018-12-03 21:18:16.243655 | primary | fatal: [undercloud]: FAILED! => {
2018-12-03 21:18:16.243780 | primary | "changed": false,
2018-12-03 21:18:16.243878 | primary | "name": "kvm-intel",
2018-12-03 21:18:16.243954 | primary | "params": "nested=1",
2018-12-03 21:18:16.244010 | primary | "rc": 1,
2018-12-03 21:18:16.244073 | primary | "state": "present"
2018-12-03 21:18:16.244105 | primary | }
2018-12-03 21:18:16.244136 | primary |
2018-12-03 21:18:16.244176 | primary | STDERR:
2018-12-03 21:18:16.244216 | primary |
2018-12-03 21:18:16.244356 | primary | modprobe: ERROR: could not insert 'kvm_intel': Operation not supported
2018-12-03 21:18:16.244387 | primary |
2018-12-03 21:18:16.244417 | primary |
2018-12-03 21:18:16.244447 | primary |
2018-12-03 21:18:16.244483 | primary | MSG:
2018-12-03 21:18:16.244513 | primary |
2018-12-03 21:18:16.244645 | primary | modprobe: ERROR: could not insert 'kvm_intel': Operation not supported
2018-12-03 21:18:16.244675 | primary |
2018-12-03 21:18:16.290161 | primary |

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-04: Fix proposed to tripleo-quickstart-extras (master)

Fix proposed to branch: master
Review: https://review.openstack.org/621907

Changed in tripleo:
assignee:	nobody → Rafael Folco (rafaelfolco)
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-07: Fix merged to tripleo-quickstart-extras (master)

Reviewed: https://review.openstack.org/621907
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=e400db1e913e2d6c71192bbea1c4709522370935
Submitter: Zuul
Branch: master

commit e400db1e913e2d6c71192bbea1c4709522370935
Author: Rafael Folco <email address hidden>
Date: Tue Dec 4 01:02:46 2018 -0200

set-libvirt-type: Stop throwing a misleading failure

    This leads to issues with people figuring out the true failure.
    Now the role should check virt extensions on cpu flags and
    ignore non-fatal errors.

Change-Id: Ic7e1062585e1a17b907b7185e6ba68362763e18e
Closes-Bug: #1806496