Cinder

In Cinder, conf_key_manager logs encryption key value

Bug #1806473 reported by David Hill
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
David Hill

Bug Description

the value of the encryption key is logged. that value is sensitive and should not be logged.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/621686

Changed in cinder:
assignee: nobody → David Hill (david-hill-ubisoft)
status: New → In Progress
Revision history for this message
Eric Harney (eharney) wrote : Re: In Cinder, conf_key_manager logs encryption key value Edit

This was masked until we landed this change, which was backported through Ocata:

https://review.openstack.org/#/q/I1c404b057d1471c85bd7eaf5c096f5912293460a

Oops. :/

summary: - In Cinder, conf_key_manager logs encryption key value Edit
+ In Cinder, conf_key_manager logs encryption key value
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/621686
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d433143ba9532ff87911b29d8e1fa14c6545c967
Submitter: Zuul
Branch: master

commit d433143ba9532ff87911b29d8e1fa14c6545c967
Author: David Hill <email address hidden>
Date: Mon Dec 3 14:43:29 2018 -0500

    Add secret=true to fixed_key configuration parameter

    Add secret=true to fixed_key configuration parameter as that value
    shouldn't be logged.

    Change-Id: I21e1246769213fb7b9e283c0ed3a369cbe780650
    Closes-Bug: #1806473

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/625139

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/625140

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/rocky)

Reviewed: https://review.openstack.org/625139
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1dbcbbc9b3684caf9e312525e44a8089f6a96b3c
Submitter: Zuul
Branch: stable/rocky

commit 1dbcbbc9b3684caf9e312525e44a8089f6a96b3c
Author: David Hill <email address hidden>
Date: Mon Dec 3 14:43:29 2018 -0500

    Add secret=true to fixed_key configuration parameter

    Add secret=true to fixed_key configuration parameter as that value
    shouldn't be logged.

    Change-Id: I21e1246769213fb7b9e283c0ed3a369cbe780650
    Closes-Bug: #1806473

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/queens)

Reviewed: https://review.openstack.org/625140
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=2edfdba7ce6b6d8e404781617c34613001e17cde
Submitter: Zuul
Branch: stable/queens

commit 2edfdba7ce6b6d8e404781617c34613001e17cde
Author: David Hill <email address hidden>
Date: Mon Dec 3 14:43:29 2018 -0500

    Add secret=true to fixed_key configuration parameter

    Add secret=true to fixed_key configuration parameter as that value
    shouldn't be logged.

    Change-Id: I21e1246769213fb7b9e283c0ed3a369cbe780650
    Closes-Bug: #1806473
    (cherry picked from commit d433143ba9532ff87911b29d8e1fa14c6545c967)
    (cherry picked from commit 1dbcbbc9b3684caf9e312525e44a8089f6a96b3c)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.5

This issue was fixed in the openstack/cinder 12.0.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 13.0.3

This issue was fixed in the openstack/cinder 13.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 14.0.0.0rc1

This issue was fixed in the openstack/cinder 14.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.