tripleo

environment files not included in capabilities-map are not applied as last

Bug #1806406 reported by Jiri Tomasek on 2018-12-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Jiri Tomasek	tripleo stein-2

Bug Description

When sorting environment files, files which are not included in capabilities-map are not appended to the sorted list. Files not included in capabilities-map are usually custom files provided by the user and often further enhance configuration provided by standard files. Custom files should be appended to the sorted list.

Tags:

OpenStack Infra (hudson-openstack) on 2018-12-03

Changed in tripleo:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-10: Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/621122
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=936a599a7c6b164ea349bafbf8a198534cd65832
Submitter: Zuul
Branch: master

commit 936a599a7c6b164ea349bafbf8a198534cd65832
Author: Jiri Tomasek <email address hidden>
Date: Fri Nov 30 09:40:11 2018 +0100

Fix environments sorting

    This change ensures, that custom environments (which are not included in
    capabilities-map.yaml) are applied at the end of list of sorted environments
    rather than just skipped

Closes-Bug: #1806406
Change-Id: Ia682284eff26883434fc516aefa8591599ec4394

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-11: Fix proposed to tripleo-common (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/624322

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-13: Fix merged to tripleo-common (stable/rocky)

Reviewed: https://review.openstack.org/624322
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=b710e5305854a1fed60a96efe583d6699385cc98
Submitter: Zuul
Branch: stable/rocky

commit b710e5305854a1fed60a96efe583d6699385cc98
Author: Jiri Tomasek <email address hidden>
Date: Fri Nov 30 09:40:11 2018 +0100

Fix environments sorting

    This change ensures, that custom environments (which are not included in
    capabilities-map.yaml) are applied at the end of list of sorted environments
    rather than just skipped

    Closes-Bug: #1806406
    Change-Id: Ia682284eff26883434fc516aefa8591599ec4394
    (cherry picked from commit 936a599a7c6b164ea349bafbf8a198534cd65832)