Fix usage of "extra_tht_configs" to allow passing extra config to overcloud deploy

Bug #1806328 reported by yatin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
yatin

Bug Description

Currently "extra_tht_configs" is being handled in "overcloud-prep-config" role[1], which can be skipped like [2], this parameter is required to copy extra tht configs to undercloud and add those configs to overcloud deploy command(using fact 'extra_tht_config_args'). So this parameter and setting should move to overcloud-deploy role as it's being used only in that role.

[1] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/overcloud-prep-config/tasks/main.yml#L75-L86
[2] https://github.com/openstack/tripleo-quickstart-extras/blob/master/playbooks/multinode-overcloud-prep.yml#L6-L8

Tags: quickstart ux
yatin (yatinkarel)
tags: added: quickstart ux
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-quickstart-extras (master)

Fix proposed to branch: master
Review: https://review.openstack.org/621473

Changed in tripleo:
assignee: nobody → yatin (yatinkarel)
status: New → In Progress
Revision history for this message
Juan Antonio Osorio Robles (juan-osorio-robles) wrote :

Still working on this?

Changed in tripleo:
importance: Undecided → Medium
milestone: none → train-1
Changed in tripleo:
assignee: yatin (yatinkarel) → Alex Schultz (alex-schultz)
Changed in tripleo:
assignee: Alex Schultz (alex-schultz) → yatin (yatinkarel)
Changed in tripleo:
milestone: train-1 → train-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-quickstart-extras (master)

Reviewed: https://review.opendev.org/621473
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=4666dc02a0051e9eb7116e630986e7408480f927
Submitter: Zuul
Branch: master

commit 4666dc02a0051e9eb7116e630986e7408480f927
Author: yatin <email address hidden>
Date: Mon Dec 3 10:20:26 2018 +0530

    Move 'extra_tht_configs' tasks to overcloud-deploy role

    'extra_tht_configs' parameter is used to pass extra tht
    configs to overcloud deploy command(using 'extra_tht_config_args'
    fact), this parameter is used to modify overcloud-deploy command,
    so this patch moves the tasks associated with it to overcloud-deploy
    role.

    Closes-Bug: #1806328
    Change-Id: I4367bd554bfc06b2416fee792b5b2a91ff8f7ff8

Changed in tripleo:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.