standalone job does not run yum update during the container image prepare

[Alex Schultz]

We are currently missing the bit of code for the ContainerImagePrepare variable that will run a yum_update for the containers in the standalone jobs.

Example:
  ContainerImagePrepare:
  - push_destination: "192.168.24.1:8787"
    modify_role: tripleo-modify-image
    modify_append_tag: "-updated-20181114202934"
    modify_only_with_labels:
    - kolla_version
    modify_vars:
      tasks_from: yum_update.yml
      yum_repos_dir_path: /etc/yum.repos.d
      update_repo: "gating-repo,delorean-current"
    set:
      tag: "current-tripleo"
      namespace: "docker.io/tripleomaster"
      name_prefix: "centos-binary-"
      name_suffix: ""
      ceph_namespace: "docker.io/ceph"
      ceph_image: "daemon"
      ceph_tag: "v3.1.0-stable-3.1-luminous-centos-7-x86_64"
      openshift_tag: "v3.11.0"

We're just using a standard openstack container image prepare default[0] to generate the ContainerImagePrepare value for the standalone. This needs to also include the modify_vars bits so we update the containers.

[0] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/standalone/templates/standalone-container-prep.sh.j2

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/621517

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/624357

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/624357
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=62b54268af4c341288e745c356f28124f61e9d2b
Submitter: Zuul
Branch: master

commit 62b54268af4c341288e745c356f28124f61e9d2b
Author: Quique Llorente <email address hidden>
Date: Tue Dec 11 12:12:19 2018 +0100

    Run local registry and prep cont at standalone

    The standalone job were not running yum update on the containers, to do
    so we need to specify the updater paremters in the
    container-prepare-parameters [1] and also we have to activate the docker
    local registry, call the conatiner prepare service and activate registry at
    podman.

    [1] https://review.openstack.org/#/c/621517/

    Change-Id: I74e817bc9b9dd522db3da7753c91a3884d99f8c8
    Related-Bug: #1805968

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/624869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/621517
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=19e62a6553feee0ee413ccc8af4dfc26927cc70e
Submitter: Zuul
Branch: master

commit 19e62a6553feee0ee413ccc8af4dfc26927cc70e
Author: Quique Llorente <email address hidden>
Date: Mon Dec 3 10:21:57 2018 +0100

    Add updates to standalone containers prep

    Standalone job was not running updates at containers, so we were not
    using latest versions of package or even stuff from gating repo. this
    patch add this to the generated default parameters.

    Change-Id: Ia83944a54ab6b0410e4e4e48dbef6602a17724be
    Closes-Bug: #1805968

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/624869
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c7d10a55a64e4efe967cec795c90bdd5ff55702e
Submitter: Zuul
Branch: stable/rocky

commit c7d10a55a64e4efe967cec795c90bdd5ff55702e
Author: Quique Llorente <email address hidden>
Date: Tue Dec 11 12:12:19 2018 +0100

    Run local registry and prep cont at standalone

    The standalone job were not running yum update on the containers, to do
    so we need to specify the updater paremters in the
    container-prepare-parameters [1] and also we have to activate the docker
    local registry and call the conatiner prepare service.

    [1] https://review.openstack.org/#/c/621517/

    NOTE: this change differs from master as we do not have a podman service
    in Rocky.
    Related-Bug: #1808591

    Change-Id: I74e817bc9b9dd522db3da7753c91a3884d99f8c8
    Related-Bug: #1805968
    (cherry picked from commit 62b54268af4c341288e745c356f28124f61e9d2b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.