mistral unit tests failing in dlrn build of tripleo-common

[wes hayutin]

http://logs.openstack.org/39/619039/1/gate/tripleo-ci-centos-7-containers-multinode/56bf0b8/logs/delorean_logs/7f/63/7f638090124fd8cbacf9390ce5b26e72215a7761_dev/build.log.txt.gz

several issues, but e.g.

tripleo_common.tests.actions.test_heat_capabilities.GetCapabilitiesActionTest.test_run_env_missing ... ERROR [tripleo_common.actions.heat_capabilities] Error retrieving environment for plan test-container: test-container
Traceback (most recent call last):
  File "/builddir/build/BUILD/tripleo-common-10.1.1.dev90/tripleo_common/actions/heat_capabilities.py", line 65, in run
    env = plan_utils.get_env(swift, self.container)
  File "/builddir/build/BUILD/tripleo-common-10.1.1.dev90/tripleo_common/utils/plan.py", line 47, in get_env
    swift.get_object(name, constants.PLAN_ENVIRONMENT)[1]
  File "/usr/lib/python2.7/site-packages/mock/mock.py", line 1062, in __call__
    return _mock_self._mock_call(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/mock/mock.py", line 1123, in _mock_call
    raise result
ClientException: test-container
ok
test_run_yaml_error (tripleo_common.

See log stash
http://logstash.openstack.org/#dashboard/file/logstash.json?query=(message%3A%5C%22ERROR%3Adlrn%3AReceived%20exception%20Error%20in%20build_rpm_wrapper%5C%22)%20AND%20tags%3Aconsole%20AND%20voting%3A1

[wes hayutin (weshayutin)]

notes for ruck/rover
Please add the unit test logs to the logstash file so we can query these issues

http://logs.openstack.org/39/619039/1/gate/tripleo-ci-centos-7-standalone/c0b3623/logs/delorean_logs/9d/2d/9d2d263ff06c9fb110c382dda464549733a33a3f_dev/build.log.txt.gz

add them here:
https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/collect-logs/defaults/main.yml#L152

[Adriano Petrich (apetrich)]

Seems to be from tripleo-common unit tests like

https://github.com/openstack/tripleo-common/blob/master/tripleo_common/tests/actions/test_deployment.py#L455

[Adriano Petrich (apetrich)]

So the error is that somehow we are receiving an string with an extra new line

Like:

reference = Result [data=None, error='Error during stack creation: ERROR: Oops', cancel=False]
actual = Result [data=None, error=u'Error during stack creation: ERROR: Oops\n', cancel=False]

Reference was what the test was expecting and actual is the actual call. The difference is thean extra new line ("\n") at the end.

The problem is that I can't reproduce that on local tests. If I add that new line to the tests the local call to tox fails

THIS IS LOCAL TOX IF WE ADD THE NEWLINE
reference = Result [data=None, error='Error during stack update: ERROR: Oops\n', cancel=False]
actual = Result [data=None, error=u'Error during stack update: ERROR: Oops', cancel=False]

I've tried to see what has changed on tripleo-common or python-heatclient but was unable to find a smoking gun.

Any ideas would be very welcome.

[Thomas Herve (therve)]

That's not an issue. The tests failures are correct, in particular https://review.openstack.org/#/c/619039/ has broken tests.

[Adriano Petrich (apetrich)]

Oh the errors were related to that patch alone.

[Adriano Petrich (apetrich)]

The bug is related to a unmerged patch. The bug the patch addresses (https://bugs.launchpad.net/tripleo/+bug/1804268) has no relation to this error. Any unit test errors introduced by the patch will fixed by the patch itself before merging.