Rocky undercloud upgrade broken by backport

Bug #1805830 reported by Jiří Stránský
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Unassigned

Bug Description

** Running ansible online upgrade tasks **
Exception: 'Deploy' object has no attribute 'ansible_playbook_cmd'
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/tripleo_deploy.py", line 1121, in _standalone_deploy
    rc = self._launch_ansible_online_upgrade(self.ansible_dir)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/tripleo_deploy.py", line 763, in _launch_ansible_online_upgrade
    cmd = [self.ansible_playbook_cmd, '-i', playbook_inventory,
AttributeError: 'Deploy' object has no attribute 'ansible_playbook_cmd'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/620897

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/rocky)

Reviewed: https://review.openstack.org/620897
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=a0305b45acd60fb46c8ee278c44f98dcf3d86a49
Submitter: Zuul
Branch: stable/rocky

commit a0305b45acd60fb46c8ee278c44f98dcf3d86a49
Author: Jiri Stransky <email address hidden>
Date: Thu Nov 29 13:19:13 2018 +0100

    [Rocky] Fix backport of undercloud online upgrade

    In Rocky, self.ansible_playbook_cmd is not defined so we hardcode
    'ansible-playbook', same as in the _launch_ansible_upgrade function.

    Closes-Bug: #1805830
    Change-Id: I85947ed64558f83d6ba2c59d67a2fde6f778ad8b

tags: added: in-stable-rocky
Revision history for this message
Natal Ngétal (hobbestigrou) wrote :

It's merged so the ticket can be closed.

Changed in tripleo:
status: Triaged → Fix Committed
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 10.6.1

This issue was fixed in the openstack/python-tripleoclient 10.6.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.