We shouldn't allow update of attachment records on volumes in error state
Bug #1805762 reported by
John Griffith
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Medium
|
John Griffith |
Bug Description
Currently we don't do any sort of status checks when updating Attachment objects on a Volume. This may or may not be "ok", we might want to consider adding a check at the API layer to reject calls to update attachments in the new Attachment API's if a volume is in an error state.
Note that since the reserve action was added as a requirement for the new Attachment API, we do call reserve on newly created attachments, so we're "ok" in terms of creating a new attachment, just need to check out the update.
Changed in cinder: | |
assignee: | nobody → John Griffith (john-griffith) |
Changed in cinder: | |
importance: | Undecided → Medium |
description: | updated |
summary: |
- We shouldn't allow create/update of attachment records on volumes in - error state + We shouldn't allow update of attachment records on volumes in error + state |
Changed in cinder: | |
status: | New → In Progress |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/620977 /git.openstack. org/cgit/ openstack/ cinder/ commit/ ?id=7d7dc2659d1 ad07ef778923068 27ca4a662e315d
Committed: https:/
Submitter: Zuul
Branch: master
commit 7d7dc2659d1ad07 ef77892306827ca 4a662e315d
Author: j-griffith <email address hidden>
Date: Thu Nov 29 18:07:58 2018 +0000
Check Volume Status on attahcment create/update
Currently the new Attachment calls in Cinder aren't checking the status
of the volume when create or update is called. This isn't good because
it can mask problems with attach processes on the volume.
This patch adds an explicit check of the volume status in both create and attachment_update, and if the volume status is in
attachment_
any error state, the call will result in an InvalidVolume exception.
This is an API change to fix a bug, and is not microversioned.
Closes-Bug: #1805762
Change-Id: I9b32c4db93879d da6490b244643de 1a18bddbbf5