Remove timeout from config download websocket

Bug #1805649 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Thomas Herve

Bug Description

Right now, the timeout is 3600, but we can reach that easily when running an external command in postconfig (those don't output anything).

Thomas Herve (therve)
Changed in tripleo:
assignee: nobody → Thomas Herve (therve)
importance: Undecided → High
milestone: none → stein-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/620627

Changed in tripleo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-tripleo (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/620912

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/620925

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/620912
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=abf98e1a9928660de8f6f49f50ae11c4b1d433e7
Submitter: Zuul
Branch: master

commit abf98e1a9928660de8f6f49f50ae11c4b1d433e7
Author: Thomas Herve <email address hidden>
Date: Thu Nov 29 14:33:46 2018 +0100

    Increase websocket timeout

    We can get into situation where the timeout is reached after 1h whereas
    we still wait for messages.

    Change-Id: Ibacc703bbbc711b4bab837f9897826864bb84dc7
    Related-Bug: #1805649

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/rocky)

Reviewed: https://review.openstack.org/620925
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=b9171e072804e7290211555f0290e904625eb293
Submitter: Zuul
Branch: stable/rocky

commit b9171e072804e7290211555f0290e904625eb293
Author: Thomas Herve <email address hidden>
Date: Wed Nov 28 16:19:24 2018 +0100

    Remove timeout in config-download

    We can reach it easily with long-running command, let's remove it.

    Change-Id: I9574597b0f4129d26ca2d09f7d3c9b67a4212bda
    Closes-Bug: #1805649
    (cherry picked from commit 5d5c86788778f01c9c2ee697aa7cbd08ca0d440c)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-tripleo (stable/rocky)

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/623339

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-tripleo (stable/rocky)

Reviewed: https://review.openstack.org/623339
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=ee80be0cef5a85a6401feba6522ccebcf443701b
Submitter: Zuul
Branch: stable/rocky

commit ee80be0cef5a85a6401feba6522ccebcf443701b
Author: Thomas Herve <email address hidden>
Date: Thu Nov 29 14:33:46 2018 +0100

    Increase websocket timeout

    We can get into situation where the timeout is reached after 1h whereas
    we still wait for messages.

    Change-Id: Ibacc703bbbc711b4bab837f9897826864bb84dc7
    Related-Bug: #1805649
    (cherry picked from commit abf98e1a9928660de8f6f49f50ae11c4b1d433e7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/620627
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=5d5c86788778f01c9c2ee697aa7cbd08ca0d440c
Submitter: Zuul
Branch: master

commit 5d5c86788778f01c9c2ee697aa7cbd08ca0d440c
Author: Thomas Herve <email address hidden>
Date: Wed Nov 28 16:19:24 2018 +0100

    Remove timeout in config-download

    We can reach it easily with long-running command, let's remove it.

    Change-Id: I9574597b0f4129d26ca2d09f7d3c9b67a4212bda
    Closes-Bug: #1805649

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 11.2.0

This issue was fixed in the openstack/python-tripleoclient 11.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 10.6.1

This issue was fixed in the openstack/python-tripleoclient 10.6.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/722648

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (stable/stein)

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/723633

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (stable/rocky)

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/723634

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/722648
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=934d713ac5f3c9a15339e79f4d599ed62ad5612e
Submitter: Zuul
Branch: stable/train

commit 934d713ac5f3c9a15339e79f4d599ed62ad5612e
Author: Rabi Mishra <email address hidden>
Date: Fri Apr 24 14:42:02 2020 +0530

    [stable only] Remove timeout in config-download-export

    With large number of nodes this can run for more than the
    default timeout of 360s as we do fetch the whole config
    from heat and generate the playbooks and the workflow can
    timeout very easily.

    This was removed for config-download worflow with
    https://review.opendev.org/620627

    Related-Bug: #1805649
    Change-Id: Ib413a40a63c9d79e7387f854167d80a105888337

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (stable/rocky)

Change abandoned by "Marios Andreou <email address hidden>" on branch: stable/rocky
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/723634
Reason: rocky is EOL since http://lists.openstack.org/pipermail/openstack-discuss/2021-March/020912.html please abandon this patch

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (stable/stein)

Change abandoned by "Marios Andreou <email address hidden>" on branch: stable/stein
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/723633
Reason: branch is going EOL see http://lists.openstack.org/pipermail/openstack-discuss/2021-July/023537.html

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.