service_plugins gets rocky values for queens

[Xav Paice]

On a cloud recently upgraded to queens, we've lost lbaas, because in the neutron.conf on the api hosts:

# queens
###############################################################################
# [ WARNING ]
# Configuration file maintained by Juju. Local changes may be overwritten.
# Restart trigger db06c350-d6a9-491a-8edc-9794c6c9e6c6
###############################################################################
[DEFAULT]
verbose = False
debug = False
use_syslog = False
state_path = /var/lib/neutron
bind_host = 0.0.0.0
auth_strategy = keystone
api_workers = 8
rpc_workers = 8

router_distributed = False

l3_ha = True
max_l3_agents_per_router = 2
min_l3_agents_per_router = 2
bind_port = 9686
core_plugin = neutron.plugins.ml2.plugin.Ml2Plugin
service_plugins = router,firewall,metering,segments,neutron_dynamic_routing.services.bgp.bgp_plugin.BgpPlugin,qos

This service_plugins list is from neutron_api_context.py which appears to have

service_plugins = {
                'icehouse': [
                    ('neutron.services.l3_router.l3_router_plugin.'
                     'L3RouterPlugin'),
                    'neutron.services.firewall.fwaas_plugin.FirewallPlugin',
                    'neutron.services.loadbalancer.plugin.LoadBalancerPlugin',
                    'neutron.services.vpn.plugin.VPNDriverPlugin',
                    ('neutron.services.metering.metering_plugin.'
                     'MeteringPlugin')],
                'juno': [
                    ('neutron.services.l3_router.l3_router_plugin.'
                     'L3RouterPlugin'),
                    'neutron.services.firewall.fwaas_plugin.FirewallPlugin',
                    'neutron.services.loadbalancer.plugin.LoadBalancerPlugin',
                    'neutron.services.vpn.plugin.VPNDriverPlugin',
                    ('neutron.services.metering.metering_plugin.'
                     'MeteringPlugin')],
                'kilo': ['router', 'firewall', 'lbaas', 'vpnaas', 'metering'],
                'liberty': ['router', 'firewall', 'lbaas', 'vpnaas',
                            'metering'],
                'mitaka': ['router', 'firewall', 'lbaas', 'vpnaas',
                           'metering'],
                'newton': ['router', 'firewall', 'vpnaas', 'metering',
                           ('neutron_lbaas.services.loadbalancer.plugin.'
                            'LoadBalancerPluginv2')],
                'ocata': ['router', 'firewall', 'vpnaas', 'metering',
                          ('neutron_lbaas.services.loadbalancer.plugin.'
                           'LoadBalancerPluginv2'), 'segments',
                          ('neutron_dynamic_routing.'
                           'services.bgp.bgp_plugin.BgpPlugin')],
                'pike': ['router', 'firewall', 'metering', 'segments',
                         ('neutron_lbaas.services.loadbalancer.plugin.'
                          'LoadBalancerPluginv2'),
                         ('neutron_dynamic_routing.'
                          'services.bgp.bgp_plugin.BgpPlugin')],
                'rocky': ['router', 'firewall', 'metering', 'segments',
                          ('neutron_dynamic_routing.'
                           'services.bgp.bgp_plugin.BgpPlugin')],
            }

(no queens).

[Xav Paice (xavpaice)]

Utterly ugly and fast patch at cs:~xavpaice/neutron-api :

diff --git a/hooks/neutron_api_context.py b/hooks/neutron_api_context.py
index 33558fe..536f88e 100644
--- a/hooks/neutron_api_context.py
+++ b/hooks/neutron_api_context.py
@@ -542,6 +542,11 @@ class NeutronCCContext(context.NeutronContext):
                           'LoadBalancerPluginv2'),
                          ('neutron_dynamic_routing.'
                           'services.bgp.bgp_plugin.BgpPlugin')],
+ 'queens': ['router', 'firewall', 'metering', 'segments',
+ ('neutron_lbaas.services.loadbalancer.plugin.'
+ 'LoadBalancerPluginv2'),
+ ('neutron_dynamic_routing.'
+ 'services.bgp.bgp_plugin.BgpPlugin')],
                 'rocky': ['router', 'firewall', 'metering', 'segments',
                           ('neutron_dynamic_routing.'
                            'services.bgp.bgp_plugin.BgpPlugin')],

I'm not even submitting that as a change as it needs tests and so on.

[Edward Hope-Morley (hopem)]

I think this was caused by the merge of Q and R templates in https://bugs.launchpad.net/horizon/+bug/1788631

[Edward Hope-Morley (hopem)]

https://bugs.launchpad.net/charm-neutron-api/+bug/1788631

[Xav Paice (xavpaice)]

subscribed field-medium - this prevents upgrading to 18.11 with Queens.

[James Page (james-page)]

@hopem - the root cause is the introduction of the octavia support and the new lbaasv2-proxy code.

@xavprice your fix is fine - working that now.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/623506

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/623506
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-api/commit/?id=54fdd53b15e9e78fff4ddfd3115a8560679bae32
Submitter: Zuul
Branch: master

commit 54fdd53b15e9e78fff4ddfd3115a8560679bae32
Author: James Page <email address hidden>
Date: Fri Dec 7 14:46:37 2018 +0000

    Fix service plugins for Queens release

    Introduction of the Octavia support for Rocky introduced a regression
    for Queens deployments where the LBaaS v2 service plugin is dropped
    from the service plugin list.

    Provide an explicit list of service plugins for Queens to resolve
    this issue.

    Change-Id: I8527e68dca01723f6d9bf04b5fe1a605f967244a
    Closes-Bug: 1805573

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.11
Review: https://review.openstack.org/624050

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/624050
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-api/commit/?id=191574e1baaccc825d57bd9889131b27b2856a6b
Submitter: Zuul
Branch: stable/18.11

commit 191574e1baaccc825d57bd9889131b27b2856a6b
Author: James Page <email address hidden>
Date: Fri Dec 7 14:46:37 2018 +0000

    Fix service plugins for Queens release

    Introduction of the Octavia support for Rocky introduced a regression
    for Queens deployments where the LBaaS v2 service plugin is dropped
    from the service plugin list.

    Provide an explicit list of service plugins for Queens to resolve
    this issue.

    Change-Id: I8527e68dca01723f6d9bf04b5fe1a605f967244a
    Closes-Bug: 1805573
    (cherry picked from commit 54fdd53b15e9e78fff4ddfd3115a8560679bae32)