"Delete dangling tracks" creates air wire

[Ken Shirriff]

"Delete dangling tracks" created an air wire when everything was connected before.

To reproduce:
1. Run DRC on attached file. Everything is connected.
2. Run Edit -> Cleanup tracks and vias -> Delete dangling tracks

Expected result: no air wires
Observed result: an air wire appeared and shows up in DRC

The problem appears to be triggered by a via with a slightly unaligned wire. Apparently DRC is happy with the via but cleanup is not.

I asked about this on the forum (https://forum.kicad.info/t/delete-dangling-tracks-creates-air-wires/13877) and was told to file a bug.

Application: pcbnew
Version: (5.0.1-3-g963ef8bb5), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.4 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.2.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 10.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision 7b2f2452833abb8cc15b844771d094870ab97a3d
https://git.launchpad.net/kicad/patch/?id=7b2f2452833abb8cc15b844771d094870ab97a3d

[Wayne Stambaugh (stambaughw)]

@Seth, does this impact the stable 5 branch?

[Seth Hillbrand (sethh)]

Yes. I haven't cherry-picked as I thought the plan was 5.1 next unless there was a 5.0.2 crash bug.

[Wayne Stambaugh (stambaughw)]

As long as the output (gerbers) isn't impacted in any way then I guess we can push this off until 5.1. I consider output integrity even a higher priority than a crash bug.