Subsequent closed days that follow a partial closed day are not being recognized

[Steve Callender]

This was tested in 3.1 with closed dates.

I know it's not ideal to have back to back closed dates, but rather have just one with multiple days, but I came across a curious issue.

When scheduling a partial closed date, followed by a full closed date, I'm seeing that Evergreen is ignoring the second full closed date.

For example,

Partial closed date

2018-12-24 16:00:00.669-05 to 2018-12-24 23:59:00.669-05 (This is a partial day closing)
2018-12-25 00:00:00.986-05 to 2018-12-25 23:59:59.714-05 (This is a full day closing)

When I check this in srfsh directly calling open-ils.storage.actor.org_unit.closed_date.overlap, it looks correct,

Received Data: {
  "end":"2018-12-26T00:00:59-05:00",
  "start":"2018-12-24T15:59:00-05:00"
}

But when Evergreen calculates it, it's not,

CALL: open-ils.storage open-ils.storage.actor.org_unit.closed_date.overlap 4, 2018-12-24T16:40:22-0500
circ due data / close date overlap found : due_date=2018-12-24T16:40:22-0500 start=2018-12-24T15:59:00-05:00, end=2018-12-25T00:00:00-05:00

It looks like Evergreen is just taking that first partial closing date and ignoring the second full one in it's calculation.

[Steve Callender (stevecallender)]

I corrected the original horrendous title I had made for this bug. Apparently it just used my search terms when I was looking for related bugs.

[Robert J Jackson (rjackson-deactivatedaccount)]

I can confirm that for two consecutive calendar days marked as closed when an item falls due on the first date the due date is set to the second closed date without checking for other closed date entries.

this on 3.2

[Anna Goben (agoben)]

It doesn't just seem to affect partial days. If you enter full closed dates as separate entries (NYE and then New Year's Day since they're in different years, for example), the second date is ignored.

3.2.1

[Josh Stompro (u-launchpad-stompro-org)]

I tested this out and couldn't replicate the problem on 3.11.1 using two adjacent closed days. I'll try and replicate the original partial + full closure and see if that triggers it either, along with logs.

Josh

[Steven Mayo (stmayo)]

It's possible this was fixed by the fix for https://bugs.launchpad.net/evergreen/+bug/1818912, which is now in 3.11.
All days after the first day of a closure, partial or not, were incorrectly being considered open when calculating how to update due dates. This could be an effect of the same issue.

[Josh Stompro (u-launchpad-stompro-org)]

Thanks Steven, I tested the partial + full day closing, and it seems like it works correctly also. I think this one is resolved.
Josh

[Terran McCanna (tmccanna)]

Yay, I love it when we get to close extra bugs! Marking this one Won't Fix since it was fixed in the other work.