dashboard - consider dropping use of floppyforms?

[Corey Bryant]

Would it be possible to drop use of django-floppyforms from murano-dashboard? It doesn't seem to be very well supported anymore. Scrolling through the issues there are several unanswered for a long time [1] and there's not been a release in a long time [2]. This makes supporting the package in distros difficult in terms of support. The package was dropped from Ubuntu in Xenial (likely due to lack of use). In murano-dashboard, django-floppyforms was recently added to requirements.txt in commit caaa9ea88d163dc089c422d511c48ca93e9261f1, although it's use in the code appears to have been around for a while.

[1] https://github.com/gregmuellegger/django-floppyforms/issues
[2] https://github.com/gregmuellegger/django-floppyforms/releases

[Corey Bryant (corey.bryant)]

I'm not sure this code is even used.

muranodashboard/common/widgets.py is the only module that imports from floppyforms, and floppyforms is used by class TriStateCheckboxSelectMultiple.

The only place TriStateCheckboxSelectMultiple is referenced is in muranodashboard/common/fields.py, in the TriStateMultipleChoiceField class.

However the TriStateMultipleChoiceField class never appears to be used. Here's a recursive grep through the murano-dashboard code:

murano-dashboard$ grep -r TriStateMultipleChoiceField
muranodashboard/common/fields.py:class TriStateMultipleChoiceField(forms.ChoiceField):

[zhurong (zhu-rong)]

this is due to next part of the code haven't merged yet
https://review.openstack.org/#/c/168027/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/639482

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/639482
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=dc0bc457139214251e483ed279f99c0cbafd1a7b
Submitter: Zuul
Branch: master

commit dc0bc457139214251e483ed279f99c0cbafd1a7b
Author: zhurong <email address hidden>
Date: Tue Feb 26 15:47:27 2019 +0800

    Remove the dependency of floppyforms

    django-floppyforms is not very well supported anymore
    and was dropped from Ubuntu in Xenial.

    Closes-bug: #1805193
    Change-Id: I46bf2d43794a67a4dc080afa9f1740a582cb7631

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano-dashboard 8.0.0.0rc1 release candidate.