image_uploader: a registry is seen as secure if URL returns 404

[Emilien Macchi]

There is a bug in the code where if the URL of the registry is returning 404 (e.g. a satellite URL which provides the image), we don't test SSL at all and the registry is considered as secured. Which is wrong.

We need to test SSL on an URL that returns something so DockerInsecureRegistryAddress gets properly populated.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/620117

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/620168

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/620172

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/620168
Reason: Clearing the gate. Do not retore this until being given the all clear. See http://lists.openstack.org/pipermail/openstack-discuss/2018-November/000368.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620172
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=58ff892e7830802de24911c1a2000b0d15770ff1
Submitter: Zuul
Branch: stable/rocky

commit 58ff892e7830802de24911c1a2000b0d15770ff1
Author: Emilien Macchi <email address hidden>
Date: Mon Nov 26 17:00:45 2018 -0500

    image_uploader: use /v2 suffix to validate SSL

    When testing if the registry is secure or not, let's use the actual
    registry URL which containers /v2 so we don't hit 404 when Satellite is
    used and provides another web server configuration.

    Change-Id: I356d00b2c730903c9276b19a676cdd524121945b
    Closes-Bug: #1805184
    (cherry picked from commit 3a0cc642b5e5e4ecf42f673a5dbb7f5fa1c9053d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620168
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=3a0cc642b5e5e4ecf42f673a5dbb7f5fa1c9053d
Submitter: Zuul
Branch: master

commit 3a0cc642b5e5e4ecf42f673a5dbb7f5fa1c9053d
Author: Emilien Macchi <email address hidden>
Date: Mon Nov 26 17:00:45 2018 -0500

    image_uploader: use /v2 suffix to validate SSL

    When testing if the registry is secure or not, let's use the actual
    registry URL which containers /v2 so we don't hit 404 when Satellite is
    used and provides another web server configuration.

    Change-Id: I356d00b2c730903c9276b19a676cdd524121945b
    Closes-Bug: #1805184

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/620117
Reason: not in our plans for now

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.5.0 release.