undercloud install fails with cryptic error message if /etc/puppet does not exist

[Alex Schultz]

If someone installs the puppetlabs version of puppet rather than our packaging, the installation of the undercloud fails with an message about 'tmp' not being defined. We should improve the error messaging to explain at least why it failed. There isn't much we can do about the wrong package being used, but we can improve the failure to help point to what is wrong in this case.

[Alex Schultz (alex-schultz)]

We need to check that tmpd exists http://git.openstack.org/cgit/openstack/python-tripleoclient/tree/tripleoclient/utils.py#n1114 before attempting to do anything with it it. If tmpd is not defined then we should throw a message indicating that we could not perform the action.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/619363

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619363
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=e348fab9514f44baf1acc39633cd06bd375b4568
Submitter: Zuul
Branch: master

commit e348fab9514f44baf1acc39633cd06bd375b4568
Author: Alex Schultz <email address hidden>
Date: Wed Nov 21 14:47:13 2018 -0700

    Improve bulk symlink error handling

    If the tempdir doesn't exist, we can get a cryptic error message when
    using the bulk_symlink function. This change checks that the temp dir we
    are to use exists prior to consuming it and throws a message indicating
    the folder doesn't exist.

    Change-Id: I3a4bf279d6d1c2c35c000e7b38b147a026cfcfb4
    Closes-Bug: #1804527

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.2.0 release.