Using deprecated param ControllerEnableSwiftStorage breaks deployment

[Christian Schwede]

When deploying with ControllerEnableSwiftStorage set to False, the deployment will break on any node that uses the Swift storage role because the swift_rsync_fix container is not running properly:

os-collect-config: "stderr: sed: can't read /var/lib/kolla/config_files/src/etc/rsyncd.conf: No such file or directory",

However, even if this would work properly, it is risky because the Swift storage services (replicators, auditors etc) will be disabled even on storage nodes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/619276

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619276
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b7ebf5835c1d41b06a79e10454a8517b456f9b5c
Submitter: Zuul
Branch: master

commit b7ebf5835c1d41b06a79e10454a8517b456f9b5c
Author: Christian Schwede <email address hidden>
Date: Wed Nov 21 16:37:24 2018 +0100

    Disable deprecated parameter ControllerEnableSwiftStorage

    Setting this parameter to False not only breaks the deployment, but also
    disables important storage services on storage nodes, not only
    Controllers.

    The parameter has been marked deprecated for quite awhile, thus changing
    it to be non-effective (before removing it totally).

    Closes-Bug: 1804479

    Change-Id: I30bdc60853b6057f4f7c8c28dc88e6b151056422

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.3.0 release.