migration: if the migration is failed/stopped in the middle a 2nd run fails (pre migration resources conflict)

[Miguel Angel Ajo]

A second run will fail because the pre-migration resources are created
again:

(Request-ID: req-7aed8979-4091-42e2-aeec-1a901b2f5e2c)\n+ openstack router create ovn-migration-router-pre\n+ openstack router set --external-gateway public ovn-migration-router-pre\nMore than one Router exists with the name 'ovn-migration-router-pre'.\n+ openstack router add subnet ovn-migration-router-pre ovn-migration-subnet-pre\nMore than one Router exists with the name 'ovn-migration-router-pre'.\n++ openstack floating ip create --port
 ovn-migration-server-port-pre public -c floating_ip_address\n++ grep floating_ip_address\n++ awk '{print $4}'\nError while executing command: ConflictException: 409, {\"NeutronError\": {\"message\": \"Cannot associate floating IP 10.0.0.235 (3717e29a-e9e1-4b53-9da5-a07e4be4ef9c) with port 7a44095a-6153-4fb8-9de7-93077e8104f7 using fixed IP 172.168.199.6, as that fixed IP already has a floating IP on external network f6855347-fe63-4ff8-9c61-0d09
559d6b0a.\", \"type\": \"FloatingIPPortAlreadyAssociated\", \"detail\": \"\"}}\n+ server_ip=\n+ echo\n+ chmod 0600 /home/stack/ovn_migration/pre_migration_resources/ovn_migration_ssh_key\nchmod: cannot access '/home/stack/ovn_migration/pre_migratio

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/619275

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619275
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=c2a98b3d90548f5c0a9ca77216238c58e2bfafbc
Submitter: Zuul
Branch: master

commit c2a98b3d90548f5c0a9ca77216238c58e2bfafbc
Author: Miguel Angel Ajo <email address hidden>
Date: Wed Nov 21 16:36:08 2018 +0100

    Pre-cleanup migration resources and fix validation

    This patch avoids the duplication/conflict of resources
    (pre-migration and post-migration) if the migration was stopped
    by an error and it's retried.

    Also makes sure that a non-working validation will fail.

    Change-Id: I5ce17e23ee52e936aeee78f64fb0df127816b1bd
    Closes-Bug: #1804477

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/626577

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626577
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=b6bae4614c0341f0f4d4b9dc277639a114479221
Submitter: Zuul
Branch: stable/rocky

commit b6bae4614c0341f0f4d4b9dc277639a114479221
Author: Miguel Angel Ajo <email address hidden>
Date: Wed Nov 21 16:36:08 2018 +0100

    Pre-cleanup migration resources and fix validation

    This patch avoids the duplication/conflict of resources
    (pre-migration and post-migration) if the migration was stopped
    by an error and it's retried.

    Also makes sure that a non-working validation will fail.

    Change-Id: I5ce17e23ee52e936aeee78f64fb0df127816b1bd
    Closes-Bug: #1804477
    (cherry picked from commit c2a98b3d90548f5c0a9ca77216238c58e2bfafbc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 6.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 5.1.0 release.