When upgrade_tasks fail for one controller, other controllers continue upgrading

[Jiří Stránský]

While looking into a different bug, we noticed that when upgrade_tasks fail on one node, they still continue on other nodes. This can happen when upgrading 3 Controllers at the same time.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/619265

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619265
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=021d1b1efba054a743f73dc596e1b80d38db0bbd
Submitter: Zuul
Branch: master

commit 021d1b1efba054a743f73dc596e1b80d38db0bbd
Author: Jiri Stransky <email address hidden>
Date: Wed Nov 21 15:48:53 2018 +0100

    Stop upgrade if a task on one node fails

    When we were upgrading multiple nodes at the same time,
    e.g. controllers, and a taks on one of the nodes failed, the other
    nodes would keep upgrading. This is undersirable and can be fixed by
    adding any_errors_fatal to the Ansible plays.

    Change-Id: Iad2b5e32e955da41af4d2b8dd8ad8aa1eb5dffa9
    Closes-Bug: #1804468

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/620320

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620320
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=027493c99f074ef685f3e4c131b7b35984a0b026
Submitter: Zuul
Branch: stable/rocky

commit 027493c99f074ef685f3e4c131b7b35984a0b026
Author: Jiri Stransky <email address hidden>
Date: Wed Nov 21 15:48:53 2018 +0100

    Stop upgrade if a task on one node fails

    When we were upgrading multiple nodes at the same time,
    e.g. controllers, and a taks on one of the nodes failed, the other
    nodes would keep upgrading. This is undersirable and can be fixed by
    adding any_errors_fatal to the Ansible plays.

    Change-Id: Iad2b5e32e955da41af4d2b8dd8ad8aa1eb5dffa9
    Closes-Bug: #1804468
    (cherry picked from commit 021d1b1efba054a743f73dc596e1b80d38db0bbd)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.2.0 release.