Booking: Overlapping bookings allowed

[Adrienne Detwiler]

Evergreen 3.0.9

In Booking -> Create Reservations, the same resource can sometimes be selected and booked to different patrons for the same or overlapping time frames.

This seems to happen when the list of bookable resources is open in more than one tab, or at more than one branch. If the list of available resources has not been reloaded, you can reserve the item even when it is already booked.

[Kathryn Nesbit (knesbit)]

This is still an issue in 3.5.4.

[Jessica Cole (colejl)]

This is still an ongoing issue in 3.7.2.

[Jessica Cole (colejl)]

This is still an ongoing issue in 3-9-1.

[Jane Sandberg (sandbergja)]

Here is a branch for this issue: user/sandbergja/lp1804066-no-overlapping-bookings

Here is a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1804066-no-overlapping-bookings

Here are the testing notes from the commit message:

1. Go to the Booking > Create Reservation
2. Choose resource by type: find a resource type that only has a single resource for ease of testing.
3. Select a time slot and press Create Reservation
4. Select a patron.
5. In a second tab, repeat the steps, being sure to select the same resource and time slot, but a different patron.
6. Press Confirm Reservation in one of your tabs.
7. Confirm that the reservation was made correctly.
8. Press Confirm Reservation in the second tab.
9. Confirm that the conflicting booking does not go through.

This patch includes a small change to the concerto test data (meeting rooms can't *actually* transit from one branch to another). You will need to reload the concerto data set before successfully running the included live tests.

[Susan Morrison (smorrison425)]

Tested the scenario outlined in #5, and confirmed it would not allow for double booking whether in same or different tab (unless I marked the resource as Overbook=true). A side note: in the Confirm Reservation Details form, resource options in the Resource dropdown would sometimes be duplicated or tripled. I'm seeing this in 3.10 as well and will submit a separate bug for that.

I have tested this code and consent to signing off on it with my name, Susan Morrison, and my email address, <email address hidden>.

[Steven Mayo (stmayo)]

I have also tested this and it looks good. I noticed that when I set Overbook=true on a specific resource it used a different time selector that was more granular. I was able to set the reservation for times that weren't just every 30 minutes. Maybe a duplicate and probably outside this scope.

I have tested this code and consent to signing off on it with my name, Steven Mayo, and my email address, <email address hidden>.

[Terran McCanna (tmccanna)]

Woo, nice to get older bugs fixed! Thanks Jane & Susan & Steven!

Committed to main and pushed as far back as 3.10.