MAAS

[2.5] JavaScript tests are not executing

Bug #1804051 reported by Mike Pontillo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Newell Jensen
MAAS 2.5.0rc1

Bug Description

After noticing that a JavaScript test that should be failing was not failing and discussing it with Ant, we found that a test case in test_node_details_networking.js was using a `fit()` statement instead of an `it()` statement. Alarmingly, this causes the **entire test suite** to silently succeed.

Related branches

~newell-jensen/maas:lp1804051
Mike Pontillo (community): Approve
MAAS Lander: Pending (unittests) requested
Diff: 62 lines (+12/-4)
3 files modified
src/maasserver/static/js/angular/controllers/tests/test_node_details_networking.js (+5/-1)
src/maasserver/static/js/angular/directives/tests/test_os_select.js (+5/-2)
src/maasserver/static/js/angular/factories/nodes.js (+2/-1)
Andres Rodriguez (andreserl)
Changed in maas:
assignee: Mike Pontillo (mpontillo) → Newell Jensen (newell-jensen)
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Failing tests as of today:

https://paste.ubuntu.com/p/6BkSTvCgHP/

Newell Jensen (newell-jensen)
Changed in maas:
status: Triaged → In Progress
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.