Dry run fails to ensure that we create a new fetch_directory or use the old fetch_directory

Bug #1803986 reported by Emilien Macchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Emilien Macchi

Bug Description

Originally posted here: https://bugzilla.redhat.com/show_bug.cgi?id=1651123

Description of problem: dry run fails on task: "ensure we create a new fetch_directory or use the old fetch_directory"

How reproducible: 100%

Step to Reproduce: Try performing dry run according to docs

Actual results:

TASK [ensure we create a new fetch_directory or use the old fetch_directory] ****************************************************************************************************************************************
fatal: [undercloud]: FAILED! => {"msg": "The conditional check 'curl_get_http_status.stdout != \"200\"' failed. The error was: error while evaluating conditional (curl_get_http_status.stdout != \"200\"): 'dict object' has no attribute 'stdout'\n\nThe error appears to have been in '/home/stack/config-download/external_deploy_steps_tasks.yaml': line 215, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n GET \"{{ swift_get_url }}\"\n - fail:\n ^ here\n"}
NO MORE HOSTS LEFT **************************************************************************************************************************************************************************************************
to retry, use: --limit @/home/stack/config-download/deploy_steps_playbook.retry
PLAY RECAP **********************************************************************************************************************************************************************************************************
ceph-0 : ok=121 changed=47 unreachable=0 failed=0
ceph-1 : ok=121 changed=47 unreachable=0 failed=0
ceph-2 : ok=121 changed=47 unreachable=0 failed=0
compute-0 : ok=142 changed=64 unreachable=0 failed=0
compute-1 : ok=142 changed=64 unreachable=0 failed=0
controller-0 : ok=190 changed=102 unreachable=0 failed=0
controller-1 : ok=188 changed=101 unreachable=0 failed=0
controller-2 : ok=188 changed=101 unreachable=0 failed=0
undercloud : ok=30 changed=16 unreachable=0 failed=1

Changed in tripleo:
milestone: none → stein-2
importance: Undecided → High
status: New → Triaged
assignee: nobody → Emilien Macchi (emilienm)
status: Triaged → In Progress
tags: added: config-download rocky-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/618753

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/618898

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/618753
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=89f276cdab4a4cefe45de996f6e85f6fe75a5cb2
Submitter: Zuul
Branch: master

commit 89f276cdab4a4cefe45de996f6e85f6fe75a5cb2
Author: Emilien Macchi <email address hidden>
Date: Mon Nov 19 08:46:32 2018 -0500

    ceph: allow curl tasks to run in dry run mode

    When running dry-run, --check option is used with Ansible CLI which
    means the shell command don't actually run so the curl isn't producting
    any change. This patch fixes the tasks that relied on the curl outputs
    to only run these tasks when the curl changed and produced something.

    Change-Id: I5b722ac111db0a1b6272a95496251107e23dd764
    Closes-Bug: #1803986

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.openstack.org/618898
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9be794b24b7f17b132f6d7a89b886430b8eb6c59
Submitter: Zuul
Branch: stable/rocky

commit 9be794b24b7f17b132f6d7a89b886430b8eb6c59
Author: Emilien Macchi <email address hidden>
Date: Mon Nov 19 08:46:32 2018 -0500

    ceph: allow curl tasks to run in dry run mode

    When running dry-run, --check option is used with Ansible CLI which
    means the shell command don't actually run so the curl isn't producting
    any change. This patch fixes the tasks that relied on the curl outputs
    to only run these tasks when the curl changed and produced something.

    Change-Id: I5b722ac111db0a1b6272a95496251107e23dd764
    Closes-Bug: #1803986
    (cherry picked from commit 89f276cdab4a4cefe45de996f6e85f6fe75a5cb2)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 10.2.0

This issue was fixed in the openstack/tripleo-heat-templates 10.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.1.0

This issue was fixed in the openstack/tripleo-heat-templates 9.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.