new Angular eg-grid uses different icons

Bug #1803788 reported by Andrea Neiman
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.11
Fix Released
Medium
Unassigned

Bug Description

3.2.1

The new implementation of eg-grid makes use of new icons for the Actions and Column Settings buttons.

Rather than have the icon sets change depending on which grid one is in & whether it's new or old Angular, is it possible to use a familiar set of buttons ("Actions" for Actions, down arrow for Column Settings) and then change all of the buttons at once after all grids are converted to new Angular?

It's confusing to the user to present them with different-looking options in difference grids.

Revision history for this message
Terran McCanna (tmccanna) wrote :

+1 for consistency to the end users if feasible

Changed in evergreen:
importance: Undecided → Medium
status: New → Confirmed
tags: added: angular usability
Revision history for this message
Remington Steed (rjs7) wrote :

I agree with the sentiment, but I'd request that we standardize on the gear icon for grid configuration, rather than the down arrow. I agree with using "Actions" for the actions menu.

Andrea Neiman (aneiman)
tags: added: eg-grid
tags: removed: webstaffclient
Gina Monti (gmonti90)
tags: added: design
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

We can make the settings icons match, but not the Actions. The AngularJS and Angular interfaces use two different icon sets. The AngularJS interfaces use the Bootstrap Glyphicons (https://getbootstrap.com/docs/3.3/components/), which is a very limited subset of a larger commercial icon set. It does have a gear (glyphicon-cog), but it doesn't have the checklist icon we use for the Actions menu in Angular.

Branch with the gear icon here:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp1803788-angjs-grid-gear-icon

To test, visit any AngularJS screen with a grid (like patron search results). The last icon in the grid toolbar should now be a gear instead of the downward caret.

tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

Tested and signed off. Branch is working/user/gmcharlt/lp1803788_signoff

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Stephanie and Galen. Pushed to rel_3_11 and above.

Changed in evergreen:
milestone: none → 3.12.3
Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.