Upgrade fail during "remove old OpenvSwitch package"

[Sofer Athlan-Guyot]

Hi,

as seen there[1]:

 TASK [remove old OpenvSwitch package(s) if version doesn't match] **************
2018-11-13 14:40:20 | 2018-11-13 14:40:20.927 122096 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] [WARNING]: when statements should not include jinja2 templating delimiters
2018-11-13 14:40:20 | 2018-11-13 14:40:20.928 122096 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] such as {{ }} or {% %}. Found: {{ new_ovs_version }} != {{ current_ovs_version
2018-11-13 14:40:20 | 2018-11-13 14:40:20.928 122096 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] }}
2018-11-13 14:40:20 | 2018-11-13 14:40:20.940 122096 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] fatal: [centos-7-rax-iad-0000493027]: FAILED! => {"msg": "The conditional check '{{ new_ovs_version }} != {{ current_ovs_version }}' failed. The error was: Invalid conditional detected: unexpected indent (<unknown>, line 1)\n\nThe error appears to have been in '/home/zuul/undercloud-ansible-jwzSvy/Standalone/upgrade_tasks.yaml': line 783, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n - current_ovs_major_version|int >= 3 or current_ovs_minor_version|int >=10\n - name: remove old OpenvSwitch package(s) if version doesn't match\n ^ here\n"}

[1] http://logs.openstack.org/06/604706/32/check/tripleo-ci-centos-7-standalone-upgrade/64922b8/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz#_2018-11-13_14_40_20

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/617732

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

Oki,

this review above get us past to that error and now we have:

2018-11-13 17:52:04 | 2018-11-13 17:52:04.478 120710 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] TASK [install/upgrade OpenvSwitch LP package] **********************************
2018-11-13 17:52:08 | 2018-11-13 17:52:08.971 120710 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] fatal: [centos-7-ovh-bhs1-0000496979]: FAILED! => {"changed": false, "msg": "No package matching 'rhosp-openvswitch' found available, installed or updated", "rc": 126, "results": ["No package matching 'rhosp-openvswitch' found available, installed or updated"]}

from http://logs.openstack.org/32/617732/1/check/tripleo-ci-centos-7-standalone-upgrade/cb242c4/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz#_2018-11-13_17_52_08

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/617732
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=49e9d44d004adc25b9623acd4339fb5455ab58ea
Submitter: Zuul
Branch: master

commit 49e9d44d004adc25b9623acd4339fb5455ab58ea
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Nov 13 17:25:49 2018 +0100

    Fix ansible conditional for ovs upgrade.

    Change-Id: I3a9f56217bb365b844acdf1d65776038c5bf9378
    Closes-Bug: #1803154

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/619005

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: stable/rocky
Review: https://review.openstack.org/619005
Reason: clearing the gate

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619005
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5a64736a11a307ca7099df0cc1f673b59e50519c
Submitter: Zuul
Branch: stable/rocky

commit 5a64736a11a307ca7099df0cc1f673b59e50519c
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Nov 13 17:25:49 2018 +0100

    Fix ansible conditional for ovs upgrade.

    Change-Id: I3a9f56217bb365b844acdf1d65776038c5bf9378
    Closes-Bug: #1803154
    (cherry picked from commit 49e9d44d004adc25b9623acd4339fb5455ab58ea)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.1.0 release.