Password eye icon is reversed

Bug #1802471 reported by pengyuesheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Expired
Undecided
Unassigned

Bug Description

I think fa-eye-slash should be used when hiding passwords. fa-eye should be used when displaying passwords.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/616849

Changed in horizon:
assignee: nobody → pengyuesheng (pengyuesheng)
status: New → In Progress
Revision history for this message
Akihiro Motoki (amotoki) wrote :

There is a discussion on the proposed review.
The suggestion is to gather more examples to determine the right way.

My comment in the gerrit review:
> I know the proposed way is the way Google uses, but we need to collect more examples to decide which is a better solution. Could you collect more examples?

Revision history for this message
Akihiro Motoki (amotoki) wrote :

Based on the above comment and no active response from the author in the proposed review, I am marking it as Incomplete and clearing the assignee.

Changed in horizon:
status: In Progress → Incomplete
assignee: pengyuesheng (pengyuesheng) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for OpenStack Dashboard (Horizon) because there has been no activity for 60 days.]

Changed in horizon:
status: Incomplete → Expired
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by pengyuesheng (<email address hidden>) on branch: master
Review: https://review.openstack.org/616849
Reason: I'm sorry,I have no time to collect examples

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.