Pcbnew: Create array dialog doesn't convert dimensions

[Benoît Vernier]

When using the "Create array" dialog in Pcbnew, the dimensions are not converted to the current unit system. Instead, the number stays the same.

For example, if I set up the create array function to have a horizontal spacing of 25.4 mm and then switch to inches, the spacing will be set to 25.4 in instead of 1.0 in.

Version info:

Application: kicad
Version: (5.0.1-3-g963ef8bb5), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.4 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.0.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 10.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision 6789103961bdbe0d455d3c5dd34bb7b30bc8a12e
https://git.launchpad.net/kicad/patch/?id=6789103961bdbe0d455d3c5dd34bb7b30bc8a12e