Upgrade from queens to bionic fails

[Liam Young]

Upgrading keystone from Queens to Rocky fails with:

2018-11-08 09:25:58 INFO juju-log Re-execing hook to pickup upgraded packages
2018-11-08 09:25:58 DEBUG config-changed Traceback (most recent call last):
2018-11-08 09:25:58 DEBUG config-changed File "/var/lib/juju/agents/unit-keystone-0/charm/hooks/config-changed", line 872, in <module>
2018-11-08 09:25:58 DEBUG config-changed main()
2018-11-08 09:25:58 DEBUG config-changed File "/var/lib/juju/agents/unit-keystone-0/charm/hooks/config-changed", line 865, in main
2018-11-08 09:25:58 DEBUG config-changed hooks.execute(sys.argv)
2018-11-08 09:25:58 DEBUG config-changed File "/var/lib/juju/agents/unit-keystone-0/charm/charmhelpers/core/hookenv.py", line 909, in execute
2018-11-08 09:25:58 DEBUG config-changed self._hooks[hook_name]()
2018-11-08 09:25:58 DEBUG config-changed File "/var/lib/juju/agents/unit-keystone-0/charm/charmhelpers/contrib/openstack/utils.py", line 1466, in wrapped_f
2018-11-08 09:25:58 DEBUG config-changed restart_functions)
2018-11-08 09:25:58 DEBUG config-changed File "/var/lib/juju/agents/unit-keystone-0/charm/charmhelpers/core/host.py", line 730, in restart_on_change_helper
2018-11-08 09:25:58 DEBUG config-changed r = lambda_f()
2018-11-08 09:25:58 DEBUG config-changed File "/var/lib/juju/agents/unit-keystone-0/charm/charmhelpers/contrib/openstack/utils.py", line 1465, in <lambda>
2018-11-08 09:25:58 DEBUG config-changed (lambda: f(*args, **kwargs)), restart_map, stopstart,
2018-11-08 09:25:58 DEBUG config-changed File "/var/lib/juju/agents/unit-keystone-0/charm/charmhelpers/contrib/hardening/harden.py", line 79, in _harden_inner2
2018-11-08 09:25:58 DEBUG config-changed return f(*args, **kwargs)
2018-11-08 09:25:58 DEBUG config-changed File "/var/lib/juju/agents/unit-keystone-0/charm/hooks/config-changed", line 220, in config_changed
2018-11-08 09:25:58 DEBUG config-changed do_openstack_upgrade_reexec(configs=CONFIGS)
2018-11-08 09:25:58 DEBUG config-changed File "/var/lib/juju/agents/unit-keystone-0/charm/hooks/keystone_utils.py", line 662, in do_openstack_upgrade_reexec
2018-11-08 09:25:58 DEBUG config-changed os.execl('./hooks/config-changed-postupgrade', '')
2018-11-08 09:25:58 DEBUG config-changed File "/usr/lib/python3.6/os.py", line 527, in execl
2018-11-08 09:25:58 DEBUG config-changed execv(file, args)
2018-11-08 09:25:58 DEBUG config-changed ValueError: execv() arg 2 first element cannot be empty
2018-11-08 09:25:58 ERROR juju.worker.uniter.operation runhook.go:117 hook "config-changed" failed: exit status 1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/616544

[Liam Young (gnuoy)]

# dpkg -l | grep -E 'privsep|rootwrap'
ii python-oslo.rootwrap 5.14.1-0ubuntu1~cloud0 all allows fine filtering of shell commands to run as root - Python 2.x
ii python3-oslo.privsep 1.29.0-0ubuntu1~cloud0 all OpenStack library for privilege separation - Python 3.x
ii python3-oslo.rootwrap 5.14.1-0ubuntu1~cloud0 all allows fine filtering of shell commands to run as root - Python 3.x

[Liam Young (gnuoy)]

Start-Date: 2018-11-08 13:05:59
Commandline: apt-get --assume-yes --option=Dpkg::Options::=--force-confold install ubuntu-cloud-keyring
--
Start-Date: 2018-11-08 13:06:21
Commandline: apt-get --assume-yes --option Dpkg::Options::=--force-confnew --option Dpkg::Options::=--force-confdef dist-upgrade
--
Start-Date: 2018-11-08 13:08:16
Commandline: apt-get --assume-yes --option=Dpkg::Options::=--force-confold install nova-compute genisoimage librbd1 xfsprogs ceph-common nova-compute-kvm python3-nova python3-memcache
--
Start-Date: 2018-11-08 13:09:24
Commandline: apt-get --assume-yes purge python-nova
--
Start-Date: 2018-11-08 13:09:27
Commandline: apt-get --assume-yes autoremove --purge
--
Start-Date: 2018-11-08 13:10:44
Commandline: apt-get --assume-yes --option=Dpkg::Options::=--force-confold install python3-ceilometer
--
Start-Date: 2018-11-08 13:11:27
Commandline: apt-get --assume-yes --option=Dpkg::Options::=--force-confold install python3-neutron
--
Start-Date: 2018-11-08 13:11:42
Commandline: apt-get --assume-yes purge python-neutron
--
Start-Date: 2018-11-08 13:11:46
Commandline: apt-get --assume-yes autoremove --purge

[Liam Young (gnuoy)]

sorry, last two comments were made in error

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616544
Committed: https://git.openstack.org/cgit/openstack/charm-keystone/commit/?id=8bdb5d5f76839b44459fda0430720a9094676b87
Submitter: Zuul
Branch: master

commit 8bdb5d5f76839b44459fda0430720a9094676b87
Author: Liam Young <email address hidden>
Date: Thu Nov 8 13:36:05 2018 +0000

    Fix call to os.execl

    It looks like os.execl does not support an empty second argument
    under py3. This change fixes the call for py3.

    Change-Id: Iffcd2c68b03013384ad3f1d2b5e8805b84b3972a
    Closes-Bug: 1802274