GerberJob File (.gbrjob) output exports non-RFC4122 project guid

[xjn xjn]

see https://bugs.launchpad.net/kicad/+bug/1800459

is
---

...
  "GeneralSpecs":
  {
    "ProjectId":
    {
      ...
      "GUID": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
      ...
    },
...

---

Gerber GUID format should be RFC4122 Version 1 or 4 :

...
  "GeneralSpecs":
  {
    "ProjectId":
    {
      ...
      "GUID": "xxxxxxxx-xxxx-Mxxx-Nxxx-xxxxxxxxxxxx",
      ...
    },
...

---

The Gerber Job File Rev. 2018.04 : 2.4 General Specs : ... GUID ...

The Gerber Job File Rev. 2018.04 : 3.2 Basic Job File

...
   "GUID": "f81d4fae-7dec-11d0-a765-00a0c91e6bf6",
...

br
xjn

[Nick Østergaard (nickoe)]

I thought this was fixed in lp:1800459, please provide version info.

I don't quite see what the error is in your bug description.

[xjn xjn (xjnxjnxjn)]

Hi,

the bug fixed with 1800459 is for the Gerber Output Files (*.gbr).

The bug reported here is the same issue, but on Gerber Job File (*.gbrjob),
the one with the JSON-Format.

The error is in the description :

current output is in format

is

  "GUID": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",

should be

   "GUID": "xxxxxxxx-xxxx-Mxxx-Nxxx-xxxxxxxxxxxx",

---

Here an eaxample

current wrong output

   "GUID": "f81d4fae7dec11d0a76500a0c91e6bf6",

should be like

   "GUID": "f81d4fae-7dec-11d0-a765-00a0c91e6bf6",

---

Version is nightly 5.0.1-23, build from scratch yesterday.

br
xjn

Am 05.11.2018 um 11:12 schrieb Nick Østergaard:
> I thought this was fixed in lp:1800459, please provide version info.
>
> I don't quite see what the error is in your bug description.
>
> ** Tags added: export gerber
>
> ** Changed in: kicad
> Milestone: None => 5.0.2
>

[xjn xjn (xjnxjnxjn)]

The bug is in
root
<https://git.launchpad.net/kicad/tree/?id=2ff74cb3fc7be819c5035cb372037163adf6dfe2>/pcbnew
<https://git.launchpad.net/kicad/tree/pcbnew?id=2ff74cb3fc7be819c5035cb372037163adf6dfe2>/exporters
<https://git.launchpad.net/kicad/tree/pcbnew/exporters?id=2ff74cb3fc7be819c5035cb372037163adf6dfe2>/gerber_jobfile_writer.cpp
<https://git.launchpad.net/kicad/tree/pcbnew/exporters/gerber_jobfile_writer.cpp?id=2ff74cb3fc7be819c5035cb372037163adf6dfe2>
in method

|void GERBER_JOBFILE_WRITER::addJSONGeneralSpecs()|

around line 500-555.

The algorithm to generate the project GUID should be the same as in
Gerber Export (root <https://git.launchpad.net/kicad/tree/>/pcbnew
<https://git.launchpad.net/kicad/tree/pcbnew>/pcbplot.cpp
<https://git.launchpad.net/kicad/tree/pcbnew/pcbplot.cpp>).

br
xjn

Am 05.11.2018 um 11:12 schrieb Nick Østergaard:
> I thought this was fixed in lp:1800459, please provide version info.
>
> I don't quite see what the error is in your bug description.
>
> ** Tags added: export gerber
>
> ** Changed in: kicad
> Milestone: None => 5.0.2
>