OpenShift role specific variables cause warning due to missing tag

[Steven Hardy]

From mcornea:

I am trying to set OpenShiftGlusterDisks as a role specific parameter(according to [1]) and the following warning shows up:

WARNING: Following parameter(s) are not supported as role-specific inputs.
  OpenShiftGlusterDisks

This is the Heat environment file that I am using:

parameter_defaults:
  OpenShiftInfraParameters:
    OpenShiftGlusterDisks:
      - /dev/vdb

[1] https://docs.openstack.org/tripleo-docs/latest/install/advanced_deployment/role_specific_parameters.html

Reported downstream at:

https://bugzilla.redhat.com/show_bug.cgi?id=1644070

I think the problem is we're missing the role-specific tag, e.g like:

 tags:
      - role_specific

Probably we should have a validation to catch where parameters are processed for role-specific values but not appropriately tagged.

[Steven Hardy (shardy)]

Hmm my initial idea is wrong, we do have the tags, digging further...

[Steven Hardy (shardy)]

This shows we do have the tags

https://github.com/openstack/tripleo-heat-templates/blob/master/extraconfig/services/openshift-cns.yaml#L45

We then check for user parameters to ensure they match the parameters tagged:

https://github.com/openstack/tripleo-common/blob/master/workbooks/plan_management.yaml#L612

https://github.com/openstack/tripleo-common/blob/master/workbooks/plan_management.yaml#L649

So something seems to be wrong - lets see if we can confirm the issue with a recent master build.